fix: provide navigation and url in events
#2264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sadym-chromium
force-pushed
the
sadym/browsing_context/navigate/hash.py
branch
from
ce6403e
to
d9c8caa
Compare
sadym-chromium
force-pushed
the
sadym/browsing_context/navigate/hash.py
branch
from
a11d77c
to
9421853
Compare
sadym-chromium
force-pushed
the
sadym/browsing_context/navigate/hash.py
branch
from
9745007
to
3a105a6
Compare
sadym-chromium
changed the title
navigation for same-document navigationsnavigation for same-document navigations
sadym-chromium
force-pushed
the
sadym/browsing_context/navigate/hash.py
branch
from
a8ed063
to
1565132
Compare
sadym-chromium
force-pushed
the
sadym/browsing_context/navigate/hash.py
branch
from
1565132
to
fa8ceda
Compare
sadym-chromium
changed the title
navigation for same-document navigationsnavigation in events
sadym-chromium
force-pushed
the
sadym/browsing_context/navigate/hash.py
branch
2 times, most recently
from
f1f2144
to
c5ab873
Compare
sadym-chromium
changed the title
navigation in eventsnavigation and url in events
sadym-chromium
changed the title
navigation and url in eventsnavigation and url in events
sadym-chromium
force-pushed
the
sadym/browsing_context/navigate/hash.py
branch
from
c6b3a10
to
44e978f
Compare
Signed-off-by: Browser Automation Bot <browser-automation-bot@google.com>
sadym-chromium
force-pushed
the
sadym/browsing_context/navigate/hash.py
branch
from
44e978f
to
892cd02
Compare
Signed-off-by: Browser Automation Bot <browser-automation-bot@google.com>
OrKoN
approved these changes
Jun 24, 2024
sadym-chromium
pushed a commit
that referenced
this pull request
Jun 28, 2024
🤖 I have created a release *beep* *boop* --- ## [0.6.0](chromium-bidi-v0.5.24...chromium-bidi-v0.6.0) (2024-06-28) ### ⚠ BREAKING CHANGES * default behavior changed from `ignore` to `dismiss`. ### Features * body size for non-intercepted requests ([#2348](#2348)) ([ec07c7d](ec07c7d)) * respect `unhandledPromptBehavior` capability ([#2351](#2351)) ([08672b9](08672b9)) ### Bug Fixes * openerFrameId whenever possible ([#2329](#2329)) ([b3ab7ef](b3ab7ef)) * provide `navigation` and `url` in events ([#2264](#2264)) ([9f058da](9f058da)) * provide type in `browsingContext.userPromptClosed` event ([#2349](#2349)) ([1326c16](1326c16)) * request body size ([#2339](#2339)) ([28dc58b](28dc58b)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address 2 issues:
navigationinbrowsingContext.navigationStartedevent. CDP does not always provideloaderIdfor same document navigation, while WebDriver BiDi spec requires a unique navigation ID for each navigation. To address the issue, I introduced A virtual navigation id, which is returned instead of loader ID in browsing context and network events.urlinbrowsingContext.navigationStarted. The information can be received from deprecatedPage.frameScheduledNavigationCDP event.