feat!: respect unhandledPromptBehavior capability
#2351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sadym-chromium
force-pushed
the
sadym/unahandledPromptBehavior
branch
from
1e750c9
to
4f225e7
Compare
sadym-chromium
changed the title
unhandledPromptBehavior capability
sadym-chromium
force-pushed
the
sadym/UserPromptClosed
branch
from
84c4cb6
to
7f6ce26
Compare
Breaking change, as default behavior changed from `ignore` to `dismiss`.
Signed-off-by: Browser Automation Bot <browser-automation-bot@google.com>
sadym-chromium
force-pushed
the
sadym/unahandledPromptBehavior
branch
from
1b5fca9
to
b568cb5
Compare
|
the commit is not conventional, although I am not sure it should be a breaking change since it is technically a fix |
It's breaking in terms of some work would be required on Puppeteer side to keep API consistent, and some work on chromedriver is required as well. |
sadym-chromium
changed the title
unhandledPromptBehavior capabilityunhandledPromptBehavior capability
OrKoN
approved these changes
Jun 26, 2024
sadym-chromium
pushed a commit
that referenced
this pull request
Jun 28, 2024
🤖 I have created a release *beep* *boop* --- ## [0.6.0](chromium-bidi-v0.5.24...chromium-bidi-v0.6.0) (2024-06-28) ### ⚠ BREAKING CHANGES * default behavior changed from `ignore` to `dismiss`. ### Features * body size for non-intercepted requests ([#2348](#2348)) ([ec07c7d](ec07c7d)) * respect `unhandledPromptBehavior` capability ([#2351](#2351)) ([08672b9](08672b9)) ### Bug Fixes * openerFrameId whenever possible ([#2329](#2329)) ([b3ab7ef](b3ab7ef)) * provide `navigation` and `url` in events ([#2264](#2264)) ([9f058da](9f058da)) * provide type in `browsingContext.userPromptClosed` event ([#2349](#2349)) ([1326c16](1326c16)) * request body size ([#2339](#2339)) ([28dc58b](28dc58b)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: default behavior changed from
ignoretodismiss.Failing WPT tests should be addressed by web-platform-tests/wpt#46895.
unhandledPromptBehavior: {default: 'ignore'}.