Cleanup preferences #8036
Merged
Cleanup preferences #8036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koppor
reviewed
Aug 31, 2021
koppor
approved these changes
Aug 31, 2021
Siedlerchr
reviewed
Aug 31, 2021
src/main/java/org/jabref/gui/slr/ExistingStudySearchAction.java
Outdated
Show resolved
Hide resolved
btut
reviewed
Aug 31, 2021
| this.taskExecutor = taskExecutor; | ||
| this.preferencesService = preferencesService; | ||
| this.importFormatPreferneces = preferencesService.getImportFormatPreferences(); | ||
| this.stateManager = stateManager; | ||
| this.importFormatPreferences = preferencesService.getImportFormatPreferences(); |
There was a problem hiding this comment.
Why keep both preferencesService and the smaller preferences objects?
There was a problem hiding this comment.
As a temporary placeholder on the way to use only the small objects.
Siedlerchr
approved these changes
Aug 31, 2021
Siedlerchr
added a commit
that referenced
this pull request
Aug 31, 2021
* upstream/main: Switch to archive.org for site.icu-project.org Add Java Profiler Fix output when closing JabRef while indexing (#8043) Remove explicit XMP import for PDFs (#8040) Fix crosses Stop indexing on cancel (#8039) Write embedded bib in addition to XMP metadata (#8037) Cleanup preferences (#8036) Fix Search dark mode theme (#8028) Allow the search to return multiple entries. (#8038) Refactored GroupTree.fxml to plain java (#8035)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted some calls to Globals.prefs and Globals.stateManager.
Step by step.
CHANGELOG.mddescribed in a way that is understandable for the average user (if applicable)