Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Write embedded bib in addition to XMP metadata #8037

Merged
merged 12 commits into from
Aug 31, 2021
Merged

Write embedded bib in addition to XMP metadata #8037

merged 12 commits into from
Aug 31, 2021

Conversation

btut
Copy link
Contributor

@btut btut commented Aug 31, 2021 •
edited
Loading

The actions (both GUI and CLI) that wrote XMP metadata to PDFs now also embedd a bibfile.

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked documentation: Is the information available and up to date? If not created an issue at https://github.com/JabRef/user-documentation/issues or, even better, submitted a pull request to the documentation repository.

@btut btut self-assigned this Aug 31, 2021
btut pushed a commit to btut/user-documentation that referenced this pull request Aug 31, 2021
For [#8037](JabRef/jabref#8037)
90f1967
@btut btut mentioned this pull request Aug 31, 2021
Merged
Siedlerchr added a commit to JabRef/user-documentation that referenced this pull request Aug 31, 2021
@btut @Siedlerchr
Document CLI options to embedd bibfile (#365)
24b5465 
* For [#8037](JabRef/jabref#8037)

* Update en/advanced/commandline.md

Co-authored-by: Benedikt Tutzer <benedikt.tutzer@tuwien.ac.at>
Co-authored-by: Christoph <siedlerkiller@gmail.com>
@Siedlerchr Siedlerchr added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Aug 31, 2021
Siedlerchr
Siedlerchr reviewed Aug 31, 2021
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@Siedlerchr
Copy link
Member

Test downloadDoesNotOverwriteFileTypeExtension() FAILED (44.9s)

org.opentest4j.AssertionFailedError: expected: <asdf.pdf> but was: <asdf.html>
at app//org.junit.jupiter.api.AssertionUtils.fail(AssertionUtils.java:55)
at app//org.junit.jupiter.api.AssertionUtils.failNotEqual(AssertionUtils.java:62)
at app//org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:182)
at app//org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:177)
at app//org.junit.jupiter.api.Assertions.assertEquals(Assertions.java:1124)
at app//org.jabref.gui.fieldeditors.LinkedFileViewModelTest.lambda$downloadDoesNotOverwriteFileTypeExtension$4(LinkedFileViewModelTest.java:215)
at app//org.jabref.gui.util.BackgroundTask.lambda$chain$0(BackgroundTask.java:79)

Siedlerchr
Siedlerchr requested changes Aug 31, 2021
View reviewed changes
Copy link
Member

@Siedlerchr Siedlerchr left a comment •
edited by btut
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

failing test

Magically fixed.

@Siedlerchr Siedlerchr merged commit 577f51c into JabRef:main Aug 31, 2021
Siedlerchr added a commit that referenced this pull request Aug 31, 2021
@Siedlerchr
Merge remote-tracking branch 'upstream/main' into newGlobalSearch
715d068 
* upstream/main:
  Switch to archive.org for site.icu-project.org
  Add Java Profiler
  Fix output when closing JabRef while indexing (#8043)
  Remove explicit XMP import for PDFs (#8040)
  Fix crosses
  Stop indexing on cancel (#8039)
  Write embedded bib in addition to XMP metadata (#8037)
  Cleanup preferences (#8036)
  Fix Search dark mode theme (#8028)
  Allow the search to return multiple entries. (#8038)
  Refactored GroupTree.fxml to plain java (#8035)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Siedlerchr Siedlerchr Siedlerchr approved these changes

Assignees

@btut btut

Labels
status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@btut @Siedlerchr