Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix output when closing JabRef while indexing #8043

Merged
merged 4 commits into from
Aug 31, 2021
Merged

Fix output when closing JabRef while indexing #8043

merged 4 commits into from
Aug 31, 2021

Conversation

koppor
Copy link
Member

@koppor koppor commented Aug 31, 2021 •
edited by btut
Loading

@but will take over

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked documentation: Is the information available and up to date? If not created an issue at https://github.com/JabRef/user-documentation/issues or, even better, submitted a pull request to the documentation repository.

@btut btut self-assigned this Aug 31, 2021
@btut btut added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Aug 31, 2021
@btut btut marked this pull request as ready for review August 31, 2021 17:24
@koppor
Copy link
Member Author

koppor commented Aug 31, 2021 •
edited
Loading

Looks good to me! (Tested locally)

@Siedlerchr Siedlerchr merged commit 7eb7b86 into main Aug 31, 2021
@Siedlerchr Siedlerchr deleted the reduce-output-at-interrupt branch August 31, 2021 17:36
Siedlerchr added a commit that referenced this pull request Aug 31, 2021
@Siedlerchr
Merge remote-tracking branch 'upstream/main' into newGlobalSearch
715d068 
* upstream/main:
  Switch to archive.org for site.icu-project.org
  Add Java Profiler
  Fix output when closing JabRef while indexing (#8043)
  Remove explicit XMP import for PDFs (#8040)
  Fix crosses
  Stop indexing on cancel (#8039)
  Write embedded bib in addition to XMP metadata (#8037)
  Cleanup preferences (#8036)
  Fix Search dark mode theme (#8028)
  Allow the search to return multiple entries. (#8038)
  Refactored GroupTree.fxml to plain java (#8035)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@btut btut

Labels
status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@koppor @Siedlerchr @btut