Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lowercase f looks bad in version 2 #273

Closed
shabahengam opened this issue Jul 13, 2020 · 14 comments
Closed

lowercase f looks bad in version 2 #273

shabahengam opened this issue Jul 13, 2020 · 14 comments
Labels
enhancement New feature or request

Comments

@shabahengam
Copy link

shabahengam commented Jul 13, 2020

lowercase f looks bad in new version.
version 1.6.size 10.firefox
v16

version 2.size 10.firefox
v20

Xterm.size 10(ver 1.6 is up, ver 2 is bottom)
v16vs20

Xterm.size 12(ver 1.6 is up, ver 2 is bottom)
vv16v20

@philippnurullin
Copy link
Member

philippnurullin commented Jul 15, 2020

Hi @shabahengam , this is conchesus change. Isolated f, like is your example is looking more pronounced, but is its placed between other letters in a word id creates a "wave" in the x-height. This is becoming more visible if it accompanied by letters like i, j, t.

I will think on how this can be improved, but the consistency of a line is preferred, so default state of f will stay that. For example we can use contextual alternate to switch between 2 different variants of f. Surrounded by other letters f will have current construction but if it's paired with the space & don't by i, j, t, it can be the "old" construction. The drawback is that it won't work if you turn off ligatures.

@philippnurullin philippnurullin added the enhancement New feature or request label Jul 15, 2020
@shabahengam
Copy link
Author

Oh now I see that.Thanks for explanation.
left v1.6, right v2
line

@trygveaa
Copy link

Maybe the top part of the f, above the line, can be made higher?

@philippnurullin
Copy link
Member

Unfortunately we can't move the ascender in fhigher. That will break the font logic or we will need to make all the ascenders higher & this will increase the line height which is very sensitive matter of you mind the amount of text on screen.

@trygveaa
Copy link

Hm, seems like the dot in i and j already is a bit higher though?

@philippnurullin
Copy link
Member

The dot is higher, but it's a part from different system. The dot don't have the same visual weight like the stem.
The top part of f is in connection with h, b, d, k, l. All these letter need to be changed too if we modify the ascender, and after that, we will be needing to tune the diacritics, which will shift up & eliminate the space between the lines so we will start to increase the line height.

@yvvt0379
Copy link

yvvt0379 commented Jul 19, 2020

Hmmm... In my opinion, these letters are not high enough, and should be as high as (). However, that would be a tiring job -- All the glyphs, including Latin, Cyrillic and Greek, of all the 8 weights should be modified. 😔
It doesn't matter if you don't take my advice, because tastes vary from person to person.

@qgates
Copy link

qgates commented Aug 23, 2020

Yup. I'm not loving the aesthetic of the new f either. While it's more correct, it's less readable. If I understand correctly, the ascender can't be raised as it's already the height of uppercase letters, which would require basically stretching the whole typeface vertically. The alternative might be to slightly lower the horizontal stroke line of j i t etc. in order to restore consistency but give a little extra space for the top half of the f.

But I'm not sure how this would look aesthetically, ie. whether it would improve or worsen the overall aesthetic of the font (which is rather nice as-is in 1.6). So it would be an experiment.

@philippnurullin
Copy link
Member

I will rollback to the previous construction in the next release.
I'll think on smart way to handle this in later releases.

@yvvt0379
Copy link

yvvt0379 commented Sep 19, 2020

Or making it a stylistic set will be a good choice.

@Aloso
Copy link

Aloso commented Oct 14, 2020

@philippnurullin When I code, I care about readability, I don't care about aesthetics. I find JetBrains Mono very readable, the lowercase f is the only exception. It would be great if JetBrains Mono offered a alternative f with a lower horizontal bar that can be enabled if desired.

Note that Fira Code also has a lowercase f where the horizontal line is slightly lower:

fifjft

I actually like this "wave" in x-height, it gives the font a nice personality.

philippnurullin added a commit that referenced this issue Oct 21, 2020
Major changes
— Added Greek alphabet #58
— Reworked diacritics #228
— Removed x-height increasing from hinting. Affects non Retina screens. #286 #265 #272 #262 #275
— A lot of tiding up of contours to meet Google Fonts criteria
Other updated and fixes
— Ligature for 0x (hexadecimal) prefix #98
— Lowered horizontal bar in Florin to make it more distinguishable form italic f #129
— Changes the 8 construction to make it more distinguishable from B and 0 #188
— Added Changelog #263
— Variable font correctly grouped in one family with Italics #270
— Reverted to previous construction of f #273
— Corrected OneNote line height #278
— Removed kerning pair #297
— Add Overline #298
— Increased difference between hyphen, en-dash, and em-dash #318
— Removed the "tail" in the italic a
@Aloso
Copy link

Aloso commented Oct 25, 2020

@philippnurullin thank you so much for developing this font! The new version is great 👌

@lunacookies
Copy link

I guess this might be more appropriate in a different/new issue, but I think Consolas handles this really well. The top line is Consolas, the middle is JetBrains Mono, and the bottom is SF Mono. Consolas really commits to the idea of the f being an exception, and moves its crossbar far below the x-height. This harms consistency but benefits readability, with the tradeoff being clear in the design. SF Mono is the same, but opposite – the f’s crossbar aligns with that of all the other letters. I think either approach works because it’s clear that one option was chosen over the other – each font ‘owns’ the tradeoff. JetBrains Mono’s ‘halfway’ stance looks strange in my opinion because it looks like it can’t quite decide which way to go. I’d rather it either embrace the inconsistency in the name of readability like Consolas, or go the other way like SF Mono and keep the consistency. That’s just my 2¢ not as a type designer, but as someone who loves typography and typefaces.

Screen Shot 2020-10-26 at 11 42 23 pm

@awhitedev
Copy link

Just wanted to chime in and say that I really like the rollbacked style of lower-case f that we now have in the latest version.

@philippnurullin Is a possible solution to just leave it as is? Sure it doesn't line up perfectly as in the cases you've outlined above. But it reads perfectly fine in my opinion and isn't that the goal anyways?

On a side note, I'm not sure if this was intentional but the download link available on the JetBrains site is still referencing an older release from September 10th (version 2.001) I had to download the latest release with this rollback from the repo. Not a big deal, just thought you should know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

8 participants