Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Font height changed in v2.x (at least on Windows) #286

Closed
rh63 opened this issue Aug 3, 2020 · 13 comments
Closed

Font height changed in v2.x (at least on Windows) #286

rh63 opened this issue Aug 3, 2020 · 13 comments
Milestone

Comments

@rh63
Copy link

rh63 commented Aug 3, 2020

As the title says...

In v1.0.6, the world was fine:

Anmerkung 2020-08-03 233405

In v2.001, the glyphs are higher than before:

Anmerkung 2020-08-03 233330

To really see the effect, save the two images and switch back and forth between them in your preferred viewer. It really makes a difference in text editors or mail clients - a change not for the better, at least for me. YMMV... ;)

All this on Windows 10 (obviously!) 1909 Build 18363.997.

@rh63
Copy link
Author

rh63 commented Aug 4, 2020

Just tested the font update on Windows 10 2004 Build 19041.388. Same effect.

@moritzdietz
Copy link

image
Definitely can see height changes for glyphs.

@philippnurullin
Copy link
Member

@moritzdietz This is not relevant. The powerline symbols on your screenshot are not from the JetBrains Mono. Looks like they brought from NERD patch.

@radzio
Copy link

radzio commented Aug 26, 2020

Same here on Windows 10 2004, I was forced to downgrade Jetbrains Mono to 1.0.6

@moritzdietz
Copy link

moritzdietz commented Aug 26, 2020

@philippnurullin I checked and made sure to test without the patched nerdfont font.
This is the stock font:

/edit: My bad! You are correct. I was using the wrong font in my terminal emulator - I forgot to change it there.

@philippnurullin
Copy link
Member

@MicroJoe Top left is only JetBrains Mono on this image. Look at the construction of r & w in other examples. Please double check the fonts.

@gagath
Copy link

gagath commented Sep 2, 2020

@MicroJoe Top left is only JetBrains Mono on this image. Look at the construction of r & w in other examples. Please double check the fonts.

My bad, I have deleted my comment. It was totally irrelevant. My system switched to the default Monospace font instead of the new version of Jetbrains Mono. This is why it looked totally different.

@philippnurullin philippnurullin added this to the v2.003 milestone Sep 8, 2020
@csabii
Copy link

csabii commented Oct 7, 2020

+1-ing this issue as this is the case for me as well. Unfortunately the height is definitely different (fonts are taller) in the new version, it does not look like fie as in the code snippets on https://www.jetbrains.com/lp/mono/
I'm using Android Studio with Win10 (10.0.19041)

philippnurullin added a commit that referenced this issue Oct 21, 2020
Major changes
— Added Greek alphabet #58
— Reworked diacritics #228
— Removed x-height increasing from hinting. Affects non Retina screens. #286 #265 #272 #262 #275
— A lot of tiding up of contours to meet Google Fonts criteria
Other updated and fixes
— Ligature for 0x (hexadecimal) prefix #98
— Lowered horizontal bar in Florin to make it more distinguishable form italic f #129
— Changes the 8 construction to make it more distinguishable from B and 0 #188
— Added Changelog #263
— Variable font correctly grouped in one family with Italics #270
— Reverted to previous construction of f #273
— Corrected OneNote line height #278
— Removed kerning pair #297
— Add Overline #298
— Increased difference between hyphen, en-dash, and em-dash #318
— Removed the "tail" in the italic a
philippnurullin added a commit that referenced this issue Nov 9, 2020
— Vertical metrics (win, hhea, typo) made equal to prevent different line-height #334 #286
— Because of vertical metrics unification Vietnamese diacritics was made more compact in capital letters
— Added symbols □ △ ▽ ◁ ▷ ▻ ◅ ► ◄ ▪ ▫ ▴ ▾ ◂ ▸ ▵ ◃ ▹ ▿ ∘ ❮ ❯ ❰ ❱ ◌ ◯ ◎ ✕ ⚠ ⚡ ⌂ ◔ ◧ ◨ ◩ ◪ ◫ ⌄ ⌅ ◕ ⌥ ⌃ ⇧ ⌘ #277
— Added Bitcoin symbol #292
— Correction in Greek letters Θ ρ #336
@philippnurullin
Copy link
Member

Hi @csabii Can you please send the screenshots.

@rh63 Also please try to reproduce the problem with the latest version from here https://github.com/JetBrains/JetBrainsMono/tree/master/fonts

@philippnurullin philippnurullin modified the milestones: v2.200, v2.300 Nov 16, 2020
@csabii
Copy link

csabii commented Nov 16, 2020

Hi Philipp,

Attached screenshots from 1.0.6. and 2.210. I got used to the increased height in the meantime so if it is intentional than I can live with it :)

1.0.6.
mono106

2.210
mono2210

@rh63
Copy link
Author

rh63 commented Nov 16, 2020

Hi,

loke @csabii commented before: I got used to the "new" look. I did like the more compact appearance of the versions up to 1.06 better, but I learned how to live with it.

Anyway, thanks for your work and the excellent font you created!

Cheers!

@csabii
Copy link

csabii commented Nov 16, 2020

yes, a big thank you from me as well :) 👍

@philippnurullin
Copy link
Member

At the earlier version we used ttfautohinting (the hinting is a process of deforming the contour to best fit in pixel grid) without optimal settings. In the latest version the x-height increased to look more like the original, hi res contour. Basically the JB Mono looks more like v2.1xx.

Ok, looks like this issue can be closed. Thanks for the feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants