Implement pagination using auto_paginate #13
Conversation
It turns out there's no point in manually paginating; the Oktokit docs recommend the use of auto_paginate instead. This commit changes to using auto_paginate, and introduces an integration test with HTTP record and replay courtesy VCR.
|
Will make the above changes soon. I'll also have a read through the Also the VCR-based integration test is failing on Ruby 2.7, 3, and 3.1. "But it works on my machine" 🤦 I'll look into that failure too. |
* Eliminate the use of `subject`. * Use `value!` instead of `value_or`.
Requested in PR review; rationale explained at https://thoughtbot.com/blog/lets-not.
| RSpec.describe EndOfLife::Repository do | ||
| describe "#fetch" do | ||
| it "fetches all 200 repositories from an account despite exceeding page size" do | ||
| repositories = VCR.use_cassette("many_repositories") do |
There was a problem hiding this comment.
Looks like this is not using the VCR cassette. Make sure to commit the cassettes if you want CI to use them.
Be sure that the cassettes don't leak your GITHUB_TOKEN. If they do, we can just rely on mocks, instead.
There was a problem hiding this comment.
Ah! Got it. Amazing what a few hours of good sleep can do ...
It was using the cassette, and the cassette was committed, but the check for the presence of GITHUB_TOKEN happens way before the cassette is read. The fix is to set the environment variable in the spec.
Thanks for the warning re. leaking real tokens. I had already taken care of this with the following VCR configuration:
config.filter_sensitive_data("REDACTED") { ENV["GITHUB_TOKEN"] }
Note that I'm setting this to the REDACTED value expected by config. Also, this used to work locally - I must have accidentally killed the `with_env` line while rebasing against main.
* Old hash syntax * Redundant variable assignment
In addition to running specs, the default Rake task now also performs style checking with standard.
|
Awesome! Thanks for the contribution, @duncan-bayne! 🎉 |
It turns out there's no point in manually paginating; the Oktokit docs recommend the use of
auto_paginateinstead.This PR changes to using auto_paginate, and introduces an integration test with HTTP record and replay courtesy VCR. In addition to the automated integration test, I've manually verified this against a test account with 200 EOL Ruby repositories in it.
I'm not sure where the upper bound lies for auto-pagination :)
It also:
Closes #9.