Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement pagination using auto_paginate #13

Merged
merged 8 commits into from
Feb 5, 2022
Merged

Implement pagination using auto_paginate #13

merged 8 commits into from
Feb 5, 2022

Commits on Jan 31, 2022

  1. Implement pagination using auto_paginate

    It turns out there's no point in manually paginating; the Oktokit docs
    recommend the use of auto_paginate instead.
    
    This commit changes to using auto_paginate, and introduces an
    integration test with HTTP record and replay courtesy VCR.
    duncan-bayne committed Jan 31, 2022
    Configuration menu
    Copy the full SHA
    0d5eb12 View commit details
    Browse the repository at this point in the history

Commits on Feb 1, 2022

  1. Remove pry

    duncan-bayne committed Feb 1, 2022
    Configuration menu
    Copy the full SHA
    5efd01d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ac1287a View commit details
    Browse the repository at this point in the history
  3. Clean up integration spec as per PR feedback

    * Eliminate the use of `subject`.
    * Use `value!` instead of `value_or`.
    duncan-bayne committed Feb 1, 2022
    Configuration menu
    Copy the full SHA
    f9452e5 View commit details
    Browse the repository at this point in the history
  4. Replace let, subject, and before with builders

    Requested in PR review; rationale explained at
    https://thoughtbot.com/blog/lets-not.
    duncan-bayne committed Feb 1, 2022
    Configuration menu
    Copy the full SHA
    e0769d1 View commit details
    Browse the repository at this point in the history

Commits on Feb 4, 2022

  1. Fix integration spec by setting GITHUB_TOKEN

    Note that I'm setting this to the REDACTED value expected by config.
    
    Also, this used to work locally - I must have accidentally killed the
    `with_env` line while rebasing against main.
    duncan-bayne committed Feb 4, 2022
    Configuration menu
    Copy the full SHA
    d6ac865 View commit details
    Browse the repository at this point in the history

Commits on Feb 5, 2022

  1. Fix style issues identified by standardrb

    * Old hash syntax
    * Redundant variable assignment
    duncan-bayne committed Feb 5, 2022
    Configuration menu
    Copy the full SHA
    846b469 View commit details
    Browse the repository at this point in the history
  2. Add style checking to the default Rake task

    In addition to running specs, the default Rake task now also performs
    style checking with standard.
    duncan-bayne committed Feb 5, 2022
    Configuration menu
    Copy the full SHA
    1caa5ed View commit details
    Browse the repository at this point in the history