-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement pagination using auto_paginate #13
Merged
MatheusRich
merged 8 commits into
MatheusRich:main
from
duncan-bayne:9-incomplete-results
Feb 5, 2022
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
0d5eb12
Implement pagination using auto_paginate
duncan-bayne 5efd01d
Remove pry
duncan-bayne ac1287a
Move dev dependencies into Gemfile
duncan-bayne f9452e5
Clean up integration spec as per PR feedback
duncan-bayne e0769d1
Replace let, subject, and before with builders
duncan-bayne d6ac865
Fix integration spec by setting GITHUB_TOKEN
duncan-bayne 846b469
Fix style issues identified by standardrb
duncan-bayne 1caa5ed
Add style checking to the default Rake task
duncan-bayne File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
# frozen_string_literal: true | ||
|
||
require "climate_control" | ||
require "ostruct" | ||
|
||
RSpec.describe EndOfLife::Repository do | ||
describe "#fetch" do | ||
it "fetches all 200 repositories from an account despite exceeding page size" do | ||
repositories = VCR.use_cassette("many_repositories") do | ||
with_env GITHUB_TOKEN: "REDACTED" do | ||
EndOfLife::Repository.fetch(language: "ruby", user: nil, organizations: nil, repository: nil) | ||
end | ||
end | ||
expect(repositories.value!.count).to eq(200) | ||
end | ||
end | ||
end |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this is not using the VCR cassette. Make sure to commit the cassettes if you want CI to use them.
Be sure that the cassettes don't leak your GITHUB_TOKEN. If they do, we can just rely on mocks, instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah! Got it. Amazing what a few hours of good sleep can do ...
It was using the cassette, and the cassette was committed, but the check for the presence of
GITHUB_TOKEN
happens way before the cassette is read. The fix is to set the environment variable in the spec.Thanks for the warning re. leaking real tokens. I had already taken care of this with the following VCR configuration:
config.filter_sensitive_data("REDACTED") { ENV["GITHUB_TOKEN"] }