Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Techstack-beta] Download: select box style #1262

Closed
samueldr opened this issue Mar 2, 2024 · 0 comments · Fixed by #1265
Closed

[Techstack-beta] Download: select box style #1262

samueldr opened this issue Mar 2, 2024 · 0 comments · Fixed by #1265
Labels
design About the design refresh work new-techstack-beta This tag marks issues with the new tech stack during preview phase

Comments

@samueldr
Copy link
Member

samueldr commented Mar 2, 2024

This is a bit of a tough one. This issue can also be deprioritized.

The TLDR is that select boxes were not styled in the previous implementation, and that the current new implementation style is a bit... raw...

image

So, I would recommend either:

  • Apply some basic things like the usual rounding metrics, colours, etc
  • Unstyling it until it is later "properly" designed

This report is a bit unfair given the previous implementation didn't do anything, though I'm reporting since some classes were used.

@samueldr samueldr added the design About the design refresh work label Mar 2, 2024
@thilobillerbeck thilobillerbeck added the new-techstack-beta This tag marks issues with the new tech stack during preview phase label Mar 2, 2024
@thilobillerbeck thilobillerbeck linked a pull request Mar 3, 2024 that will close this issue
thilobillerbeck added a commit that referenced this issue Mar 3, 2024
- fix #1235
- fix #1246
- fix #1248
- fix #1272 
- fix #1271 
- fix #1270 
- fix #1267 
- fix #1266 
- fix #1263 
- fix #1262
- fix #1283
- fix #1282
- fix #1280
- fix #1278
- fix some regressions on the download page (though not all)

---------

Co-authored-by: Rok Garbas <rok@garbas.si>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design About the design refresh work new-techstack-beta This tag marks issues with the new tech stack during preview phase
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants