Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Techstack-beta] Homepage: Missing title tagline #1280

Closed
samueldr opened this issue Mar 3, 2024 · 1 comment · Fixed by #1265
Closed

[Techstack-beta] Homepage: Missing title tagline #1280

samueldr opened this issue Mar 3, 2024 · 1 comment · Fixed by #1265
Labels
content new-techstack-beta This tag marks issues with the new tech stack during preview phase

Comments

@samueldr
Copy link
Member

samueldr commented Mar 3, 2024

That might not be a bug, might be a different decision, but this is a notable difference.

image

For the full text:

  • nixos-homepage/layout.tt

    Lines 36 to 40 in 72fcddd

    [% IF title != "" %]
    <title>[% title %] | Nix &amp; NixOS </title>
    [% ELSE %]
    <title>Nix &amp; NixOS | Reproducible builds and deployments</title>
    [% END %]
@thilobillerbeck thilobillerbeck added the new-techstack-beta This tag marks issues with the new tech stack during preview phase label Mar 3, 2024
@thilobillerbeck
Copy link
Collaborator

hm, I remebered this working, lets see why it broke

@thilobillerbeck thilobillerbeck mentioned this issue Mar 3, 2024
Merged
@thilobillerbeck thilobillerbeck linked a pull request Mar 3, 2024 that will close this issue
fix 1235, 1246, 1248 and download page regresisons #1265
Merged
thilobillerbeck added a commit that referenced this issue Mar 3, 2024
@thilobillerbeck @garbas
fix 1235, 1246, 1248 and download page regresisons (#1265)
90f8e1f 
- fix #1235
- fix #1246
- fix #1248
- fix #1272 
- fix #1271 
- fix #1270 
- fix #1267 
- fix #1266 
- fix #1263 
- fix #1262
- fix #1283
- fix #1282
- fix #1280
- fix #1278
- fix some regressions on the download page (though not all)

---------

Co-authored-by: Rok Garbas <rok@garbas.si>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
content new-techstack-beta This tag marks issues with the new tech stack during preview phase
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix 1235, 1246, 1248 and download page regresisons NixOS/nixos-homepage
2 participants
@samueldr @thilobillerbeck