Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addon pin assignment not released after changing via webconfig #816

Closed
4 tasks done
MajorArkwolf opened this issue Jan 22, 2024 · 2 comments · Fixed by #893
Closed
4 tasks done

Addon pin assignment not released after changing via webconfig #816

MajorArkwolf opened this issue Jan 22, 2024 · 2 comments · Fixed by #893
Assignees
Labels
bug Something isn't working

Comments

@MajorArkwolf
Copy link

Prerequisites

Please check the following before posting an issue / bug report.

  • I am running the latest version of the firmware found HERE
  • I have checked the documentation HERE and found no answer
  • I checked to make sure that this issue has not already been filed HERE
  • I am reporting the issue to the correct repository

Context

Please provide all relevant information about your setup. This is important in case the issue is not reproducible except for under certain conditions.

  • Firmware Version: 0.7.7
  • Name of device: OpenCore0
  • Link to where you purchased the device: Custom Order
  • Is this a custom build?: No
  • Operating System: Windows 10
  • Browser: Firefox

Expected Behavior

Please describe the behaviour you are expecting.
When changing the pin assignment via the web config for an addon such as i2c, the previously used pins should become available for use.

Current Behavior

What is the current behaviour?
When changing the pin assignment via the webconig for an addon, the new pins will be bound, but the old pins will also remain bound even though they are no longer in use.

Steps to Reproduce

Please provide detailed steps for reproducing the issue.
Note: Running these steps will permanently lock your pins out and can not be unlocked via normal means

  1. Boot a board into the webconfig
  2. Change the D+ pin for the usb passthrough.
  3. Save and reboot into the webconfig
  4. Go to the Pin Assignment page and notice how the previous and new pins both say they are assigned to an addon.

Screenshots & Files

Please include any relevant screenshots or files here. If you are having issues with a board please include images of the front and back of the board.

@Locutus73
Copy link

I confirm I had the same issue changing pin assignment in the focus mode add-on with my RP2040 Advanced Breakout Board - USB Passthrough Edition v5.4E and GP2040-CE_0.7.7_RP2040AdvancedBreakoutBoardUSBPassthrough.uf2

@arntsonl
Copy link
Contributor

I was able to replicate on 0.7.7 using the focus mode pin.

@bsstephan I can take this on or you can grab it.

@bsstephan bsstephan added the bug Something isn't working label Mar 9, 2024
bsstephan added a commit to bsstephan/GP2040-CE that referenced this issue Mar 15, 2024
jack2game added a commit to jack2game/GP2040-CE that referenced this issue Mar 17, 2024
* Readme hotfix

* Display update fixes (OpenStickCommunity#894)

Fixed config pin defines for I2C blocks
Fixed flip/mirror modes for display

* Buzzer Speaker enable pin (OpenStickCommunity#881)

* Added optional enable pin to buzzer speaker addon to allow toggling on/off.

* Update toggle to use a boolean for later muting/unmuting.

* unassign the old addon pin after assigning the new one (OpenStickCommunity#893)

Fixes OpenStickCommunity#816

---------

Co-authored-by: Luke Arntson <arntsonl@gmail.com>
Co-authored-by: Mike Parks <mikepparks@gmail.com>
Co-authored-by: Brian S. Stephan <bss@incorporeal.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants