Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buzzer Speaker enable pin #881

Merged

Conversation

mikepparks
Copy link
Contributor

@mikepparks mikepparks commented Mar 6, 2024

Added optional enable pin to to allow toggling the sound on/off when necessary. The enable pin is pulled high on setup() if the pin is defined so it will need to be brought low to disable the speaker during runtime.

Copy link
Contributor

@arntsonl arntsonl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll need to update the docs on this, but our 0.001% of users that use buzzer will figure it out :)

@arntsonl arntsonl merged commit 0dd79f1 into OpenStickCommunity:main Mar 16, 2024
31 checks passed
jack2game added a commit to jack2game/GP2040-CE that referenced this pull request Mar 17, 2024
* Readme hotfix

* Display update fixes (OpenStickCommunity#894)

Fixed config pin defines for I2C blocks
Fixed flip/mirror modes for display

* Buzzer Speaker enable pin (OpenStickCommunity#881)

* Added optional enable pin to buzzer speaker addon to allow toggling on/off.

* Update toggle to use a boolean for later muting/unmuting.

* unassign the old addon pin after assigning the new one (OpenStickCommunity#893)

Fixes OpenStickCommunity#816

---------

Co-authored-by: Luke Arntson <arntsonl@gmail.com>
Co-authored-by: Mike Parks <mikepparks@gmail.com>
Co-authored-by: Brian S. Stephan <bss@incorporeal.org>
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants