Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unassign the old addon pin after assigning the new one #893

Merged
merged 1 commit into from
Mar 16, 2024
Merged

unassign the old addon pin after assigning the new one #893

merged 1 commit into from
Mar 16, 2024

Conversation

bsstephan
Copy link
Contributor

Fixes #816

arntsonl
arntsonl approved these changes Mar 16, 2024
View reviewed changes
Copy link
Contributor

@arntsonl arntsonl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is much cleaner, thank you! Looks great

@arntsonl arntsonl merged commit f5c7fcd into OpenStickCommunity:main Mar 16, 2024
32 checks passed
jack2game added a commit to jack2game/GP2040-CE that referenced this pull request Mar 17, 2024
@jack2game @arntsonl
@mikepparks @bsstephan
Rex main (#34)
ac0553e 
* Readme hotfix

* Display update fixes (OpenStickCommunity#894)

Fixed config pin defines for I2C blocks
Fixed flip/mirror modes for display

* Buzzer Speaker enable pin (OpenStickCommunity#881)

* Added optional enable pin to buzzer speaker addon to allow toggling on/off.

* Update toggle to use a boolean for later muting/unmuting.

* unassign the old addon pin after assigning the new one (OpenStickCommunity#893)

Fixes OpenStickCommunity#816

---------

Co-authored-by: Luke Arntson <arntsonl@gmail.com>
Co-authored-by: Mike Parks <mikepparks@gmail.com>
Co-authored-by: Brian S. Stephan <bss@incorporeal.org>
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arntsonl arntsonl arntsonl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Addon pin assignment not released after changing via webconfig
2 participants
@bsstephan @arntsonl