Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(elasticsearch): deprecate module #16530

Closed
BenChaimberg opened this issue Sep 17, 2021 · 1 comment · Fixed by #19296
Closed

(elasticsearch): deprecate module #16530

BenChaimberg opened this issue Sep 17, 2021 · 1 comment · Fixed by #19296
Labels
@aws-cdk/aws-elasticsearch Related to Amazon Elasticsearch Service effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p1

Comments

@BenChaimberg
Copy link
Contributor

Now that Elasticsearch has been rebranded as OpenSearch and the new aws-opensearchservice module has been created, the aws-elasticsearch CDK module should be deprecated. This cannot be accomplished currently since the aws-appsync module still takes a dependency on aws-elasticsearch and the v2 build will fail since deprecated modules are stripped.

Depends on #16528

This is a 🚀 Feature Request
@BenChaimberg BenChaimberg added p1 feature-request A feature should be added or improved. effort/small Small work item – less than a day of effort @aws-cdk/aws-elasticsearch Related to Amazon Elasticsearch Service labels Sep 17, 2021
@kaizencc kaizencc mentioned this issue Mar 11, 2022
Merged
@mergify mergify bot closed this as completed in #19296 Mar 15, 2022
mergify bot pushed a commit that referenced this issue Mar 15, 2022
@kaizencc
chore(elasticsearch): deprecate all APIs except ElasticsearchVersion (
122d723 
#19296)

Closes #16530.

Depends on #16529. 

This PR deprecates all APIs in `elasticsearch` in favor of the `opensearchservice` module. However, it does not deprecate `elasticsearch` as a module, since there are rules in place that disallow stable modules (like `cloudformation-include`) from depending on deprecated modules. See #19392. 

> `ElasticsearchVersion` was not deprecated due to a quirk in how the module is imported. It looks like, on import, the static properties `public static readonly V7_10 = ElasticsearchVersion.of('7.10');` actually tries to make the api call `of()`, which is deprecated. So imports fail with a message about using the deprecated api `ElasticsearchVersion.of()`.
----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
@aws-cdk/aws-elasticsearch Related to Amazon Elasticsearch Service effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p1
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(elasticsearch): deprecate all APIs except ElasticsearchVersion aws/aws-cdk
3 participants
@skinny85 @BenChaimberg @peterwoodworth