Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(elasticsearch): deprecate all APIs except ElasticsearchVersion #19296

Merged
merged 18 commits into from
Mar 15, 2022

Conversation

kaizencc
Copy link
Contributor

@kaizencc kaizencc commented Mar 8, 2022

Closes #16530.

Depends on #16529.

This PR deprecates all APIs in elasticsearch in favor of the opensearchservice module. However, it does not deprecate elasticsearch as a module, since there are rules in place that disallow stable modules (like cloudformation-include) from depending on deprecated modules. See #19392.

ElasticsearchVersion was not deprecated due to a quirk in how the module is imported. It looks like, on import, the static properties public static readonly V7_10 = ElasticsearchVersion.of('7.10'); actually tries to make the api call of(), which is deprecated. So imports fail with a message about using the deprecated api ElasticsearchVersion.of().


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Mar 8, 2022

@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Mar 8, 2022
@kaizencc kaizencc requested a review from a team March 8, 2022 23:03
packages/@aws-cdk/aws-elasticsearch/package.json Outdated Show resolved Hide resolved
@rix0rrr rix0rrr added the pr/do-not-merge This PR should not be merged at this time. label Mar 8, 2022
@kaizencc kaizencc removed the pr/do-not-merge This PR should not be merged at this time. label Mar 8, 2022
@kaizencc kaizencc added the pr/do-not-merge This PR should not be merged at this time. label Mar 10, 2022
@kaizencc kaizencc added p1 and removed pr/do-not-merge This PR should not be merged at this time. labels Mar 11, 2022
@kaizencc kaizencc changed the title chore(elasticsearch): deprecate in favor of opensearch chore(elasticsearch): deprecate all APIs in elasticsearch Mar 14, 2022
@kaizencc kaizencc added the pr/do-not-merge This PR should not be merged at this time. label Mar 14, 2022
@kaizencc kaizencc changed the title chore(elasticsearch): deprecate all APIs in elasticsearch chore(elasticsearch): deprecate all APIs except ElasticsearchVersion Mar 15, 2022
@kaizencc kaizencc removed the pr/do-not-merge This PR should not be merged at this time. label Mar 15, 2022
@mergify
Copy link
Contributor

mergify bot commented Mar 15, 2022

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: f578525
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 122d723 into master Mar 15, 2022
@mergify mergify bot deleted the conroy/deprecate-elasticsearch branch March 15, 2022 19:28
@mergify
Copy link
Contributor

mergify bot commented Mar 15, 2022

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS. p1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(elasticsearch): deprecate module
3 participants