Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(elasticsearch): properly deprecate elasticsearch #19392

Closed
1 of 2 tasks
kaizencc opened this issue Mar 14, 2022 · 1 comment
Closed
1 of 2 tasks

(elasticsearch): properly deprecate elasticsearch #19392

kaizencc opened this issue Mar 14, 2022 · 1 comment
Labels
@aws-cdk/aws-elasticsearch Related to Amazon Elasticsearch Service closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2

Comments

@kaizencc
Copy link
Contributor

Description

When #19296 is merged, all APIs in elasticsearch will be deprecated, but the module itself will not. This is because there are stable modules that depend on elasticsearch and we cannot depend on a deprecated module. Until we have a mechanism to deprecate these modules in v2, we will not truly deprecate elasticsearch.

Relevant issue is aws/jsii#3423, which is a feature request for a way to deprecate all APIs in a jsii module at once.

Use Case

n/a

Proposed Solution

n/a

Other information

No response

Acknowledge

  • I may be able to implement this feature request
  • This feature might incur a breaking change
@kaizencc kaizencc added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. p1 effort/small Small work item – less than a day of effort @aws-cdk/aws-elasticsearch Related to Amazon Elasticsearch Service and removed needs-triage This issue or PR still needs to be triaged. labels Mar 14, 2022
@kaizencc kaizencc mentioned this issue Mar 14, 2022
Merged
mergify bot pushed a commit that referenced this issue Mar 15, 2022
@kaizencc
chore(elasticsearch): deprecate all APIs except ElasticsearchVersion (
122d723 
#19296)

Closes #16530.

Depends on #16529. 

This PR deprecates all APIs in `elasticsearch` in favor of the `opensearchservice` module. However, it does not deprecate `elasticsearch` as a module, since there are rules in place that disallow stable modules (like `cloudformation-include`) from depending on deprecated modules. See #19392. 

> `ElasticsearchVersion` was not deprecated due to a quirk in how the module is imported. It looks like, on import, the static properties `public static readonly V7_10 = ElasticsearchVersion.of('7.10');` actually tries to make the api call `of()`, which is deprecated. So imports fail with a message about using the deprecated api `ElasticsearchVersion.of()`.
----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@rix0rrr rix0rrr added p2 and removed p1 labels Mar 16, 2022
@github-actions
Copy link

This issue has not received any attention in 1 year. If you want to keep this issue open, please leave a comment below and auto-close will be canceled.

@github-actions github-actions bot added closing-soon This issue will automatically close in 4 days unless further comments are made. closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. and removed closing-soon This issue will automatically close in 4 days unless further comments are made. labels Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
@aws-cdk/aws-elasticsearch Related to Amazon Elasticsearch Service closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rix0rrr @kaizencc