Vstest args for dotnet cli #9211

mayankbansal018 · 2018-05-07T06:15:03Z

Allow dotnet CLI to take multiple inputs for logger, & TAP
Complete PR: Always look for adapters in Test Source directory microsoft/vstest#1574 , then update dotnet sdk here

…tup, fsharp, sdk, templating, templating, templating, websdk to rtm-62908-03, alpha-62908-03, rtm-26508-02, rtm-26508-02, rtm-26508-02, rtm-180508-0, rtm-62908-02, beta3-20180508-1667431, beta3-20180508-1667431, beta3-20180508-1667431, rtm-20180508-1667423, respectively

…x-UpdateDependencies Update clicommandlineparser, climigrate, coresetup, coresetup, coresetup, fsharp, sdk, templating, templating, templating, websdk to rtm-62908-03, alpha-62908-03, rtm-26508-02, rtm-26508-02, rtm-26508-02, rtm-180508-0, rtm-62908-02, beta3-20180508-1667431, beta3-20180508-1667431, beta3-20180508-1667431, rtm-20180508-1667423, respectively (release/2.1.3xx)

Commit 1028950 changed the default verbosity option used for MSBuild from `-v:quiet` to `-verbosity:quiet`. This triggered a match that was being done against arguments starting with `-verbosity` to forward the value to VSTest via the `VSTestVerbosity` property. The result is that VSTest is using a default verbosity of `quiet`, suppressing error output that users expect to see. The fix is to change the check to only match against user-supplied options. The default level the command uses for MSBuild is not forwarded to VSTest. Fixes #9229.

Fix incorrect default VSTest verbosity level.

src/dotnet/commands/dotnet-test/TestCommandParser.cs

                              .With(name: LocalizableStrings.CmdTestAdapterPath)
-                              .ForwardAsSingle(o => $"-property:VSTestTestAdapterPath={o.Arguments.Single()}")),
+                              .ForwardAsSingle(o => $"/p:VSTestTestAdapterPath=\"{string.Join(";", o.Arguments)}\"")),


src/dotnet/commands/dotnet-test/Program.cs

@@ -31,7 +31,7 @@ public static TestCommand FromArgs(string[] args, string msbuildPath = null)
            var msbuildArgs = new List<string>()
            {
                "-target:VSTest",
-                "-verbosity:quiet",
+                "-verbosity:minimal",


…release/2.1.4xx Merge release/2.1.3xx to release/2.1.4xx

src/dotnet/commands/dotnet-test/TestCommandParser.cs

                              .With(name: LocalizableStrings.CmdLoggerOption)
                              .ForwardAsSingle(o =>
                                    {
                                          var loggersString = string.Join(";", GetSemiColonEscapedArgs(o.Arguments));

-                                          return $"-property:VSTestLogger={loggersString}";
+                                        return $"/p:VSTestLogger=\"{loggersString}\"";


peterhuene

Other than changing back to -property, I'm 👍

peterhuene · 2018-05-15T21:05:17Z

Also, could we rebase this off of release/2.1.4xx rather than having the merge commit (I wouldn't mind a squash too, but we can do that at merge time)?

Note that release/2.1.4xx now has the fix for the verbosity issue.

into vstestArguments

mayankbansal018 · 2018-05-16T11:10:37Z

@peterhuene , I've rebased the branch from 2.1.4xx, please do a squash merge if the changes look good to you.

mayankbansal018 · 2018-05-16T19:58:34Z

@livarcocc , @peterhuene , I'm not sure why the wip check is not passing, but can you please take a look at this PR, & merge it.

peterhuene · 2018-05-16T20:07:58Z

It's not passing because one of your commits has WIP in it.

[WIP]Update Vstest args for dotnet cli

095891a

etbyrd added the community label May 7, 2018

dotnet-maestro-bot and others added 9 commits May 9, 2018 00:31

Merge branch 'release/2.1.3xx' into release/2.1.3xx-UpdateDependencies

4919ee2

add test

4a8ef01

Merge branch 'release/2.1.4xx' into vstestArguments

d3a29c3

Fix Test

8517864

Fixing test code

77fb5c3

Merge pull request dotnet#9267 from peterhuene/fix-test-verbosity

59a27df

Fix incorrect default VSTest verbosity level.

smadala approved these changes May 14, 2018

View reviewed changes

mayankbansal018 changed the title ~~[WIP]Update Vstest args for dotnet cli~~ Update Vstest args for dotnet cli May 14, 2018

Merge branch 'release/2.1.4xx' into vstestArguments

d455a33

mayankbansal018 mentioned this pull request May 14, 2018

vstest console does not show console output from a test logger for "quiet" verbosity level microsoft/vstest#1580

Closed

mayankbansal018 and others added 2 commits May 14, 2018 12:59

revert changes for verbosity

003b499

Merge pull request dotnet#9275 from dotnet/merges/release/2.1.3xx-to-…

08b20ef

…release/2.1.4xx Merge release/2.1.3xx to release/2.1.4xx

peterhuene reviewed May 15, 2018

View reviewed changes

peterhuene suggested changes May 15, 2018

View reviewed changes

mayankbansal018 added 7 commits May 16, 2018 15:48

[WIP]Update Vstest args for dotnet cli

28f7b8e

add test

86dd27b

Fix Test

6a22c24

Fixing test code

266f547

revert changes for verbosity

64c647f

Merge branch 'vstestArguments' of https://github.com/mayankbansal018/cli

5131ec7

into vstestArguments

PR comments, using "-property" rather than "/p"

e37c423

mayankbansal018 changed the title ~~Update Vstest args for dotnet cli~~ Vstest args for dotnet cli May 16, 2018

mayankbansal018 closed this May 17, 2018

mayankbansal018 mentioned this pull request May 17, 2018

Multiple Logger/TestAdapter inputs from dotnet CLI #9302

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Vstest args for dotnet cli #9211

Vstest args for dotnet cli #9211

mayankbansal018 commented May 7, 2018 •

edited

Loading

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

peterhuene left a comment

peterhuene commented May 15, 2018

mayankbansal018 commented May 16, 2018

mayankbansal018 commented May 16, 2018

peterhuene commented May 16, 2018

Vstest args for dotnet cli #9211

Vstest args for dotnet cli #9211

Conversation

mayankbansal018 commented May 7, 2018 • edited Loading

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

peterhuene left a comment

Choose a reason for hiding this comment

peterhuene commented May 15, 2018

mayankbansal018 commented May 16, 2018

mayankbansal018 commented May 16, 2018

peterhuene commented May 16, 2018

mayankbansal018 commented May 7, 2018 •

edited

Loading