Always look for adapters in Test Source directory #1574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smadala
reviewed
May 3, 2018
| this.testHostManager.Initialize(this.mockMessageLogger.Object, $"<?xml version=\"1.0\" encoding=\"utf-8\"?><RunSettings> <RunConfiguration><TestAdaptersPaths>C:\\Foo</TestAdaptersPaths></RunConfiguration> </RunSettings>"); | ||
| List<string> currentList = new List<string> { @"FooExtension.dll" }; | ||
| List<string> currentList = new List<string> { @"FooExtension.dll", @"C:\Source1\ext1.TestAdapter.dll", @"C:\Source1\ext2.TestAdapter.dll" }; |
| @@ -192,7 +191,7 @@ public TestHostConnectionInfo GetTestHostConnectionInfo() | |||
| /// <inheritdoc/> | |||
| public IEnumerable<string> GetTestPlatformExtensions(IEnumerable<string> sources, IEnumerable<string> extensions) | |||
| { | |||
| if (sources != null && sources.Any() && this.projectOutputExtensionsRequired) | |||
| if (sources != null && sources.Any()) | |||
There was a problem hiding this comment.
Remove explicitly testadapterpath from acceptance tests. Example.
smadala
reviewed
May 4, 2018
| foreach (var arg in this.VSTestTestAdapterPath) | ||
| { | ||
| allArgs.Add("--testAdapterPath:" + ArgumentEscaper.HandleEscapeSequenceInArgForProcessStart(arg)); | ||
| } | ||
| } | ||
| else |
There was a problem hiding this comment.
We can remove else condition.
|
|
||
| if (arg.StartsWith("console", StringComparison.OrdinalIgnoreCase)) | ||
| { | ||
| initializeConsoleLogger = false; |
There was a problem hiding this comment.
Nit: Rename to isConsoleLoggerEnabled or something close to it?
| var allArguments = vstestTask.CreateArgument().ToArray(); | ||
|
|
||
| Assert.IsNotNull(allArguments.FirstOrDefault(arg => arg.Contains("--testAdapterPath:path1"))); | ||
| Assert.IsNotNull(allArguments.FirstOrDefault(arg => arg.Contains("--testAdapterPath:path1"))); |
singhsarab
approved these changes
May 4, 2018
| @@ -54,7 +54,7 @@ public string VSTestTestCaseFilter | |||
| get; | |||
| set; | |||
| } | |||
| public string VSTestLogger | |||
| public string[] VSTestLogger | |||
There was a problem hiding this comment.
Nit: Should we rename these to reflect the change, VSTestLoggers ?
| vstestTask.VSTestFramework = "abc"; | ||
|
|
||
| vstestTask.VSTestLogger = new string[] { "trx;LogFileName=foo bar.trx", "console" }; | ||
|
|
There was a problem hiding this comment.
Nit: extra line
Also, better for required properties, use new VSTestTask { TestFileFullPath = "abc", VSTestFramework = "xyz"}
cltshivash
reviewed
May 4, 2018
| @@ -31,7 +31,7 @@ public string VSTestSetting | |||
| set; | |||
| } | |||
|
|
|||
| public string VSTestTestAdapterPath | |||
| public string[] VSTestTestAdapterPath | |||
There was a problem hiding this comment.
string[] [](start = 15, length = 8)
nitpick: IEnumerable over string[]
smadala
approved these changes
May 7, 2018
|
@dotnet-bot test Windows_NT / Debug Build please |
1 similar comment
|
@dotnet-bot test Windows_NT / Debug Build please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Dotnet CLI PR: dotnet/cli#9198
Related issue
Fixes #1319