Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TestAdapterPath should work together with other lookup methods #1319

Closed
smadala opened this issue Dec 5, 2017 · 7 comments
Closed

TestAdapterPath should work together with other lookup methods #1319

smadala opened this issue Dec 5, 2017 · 7 comments

Comments

@smadala
Copy link
Contributor

smadala commented Dec 5, 2017

From @NikolayPianikov on November 17, 2017 15:8

I mean project output directory, nuget and etc.

  • We could have the identical behavior for full and core .net, I mean when I specify TestAdapterPath for .net full it does not try to find adapters in the project output directory but for .net core it properly finds.

So I should copy my custom adapter to the root of solution directory to run tests for mixed solution (with full .net and core .net projects). And vstest could spend potentially significant time finding all required adapters when agent checkout directory has a lot of files/directories. It is very important for CI.

  • It would be great if we could specify several paths separated by semicolon or add new parameter TestAdapterPaths for that to work together with other lookup methods.

Copied from original issue: microsoft/vstest-docs#103

@smadala
Copy link
Contributor Author

smadala commented Dec 5, 2017

@NikolayPianikov

It would be great if we could specify several paths separated by semicolon or add new parameter TestAdapterPaths for that to work together with other lookup methods.

You can use /TestAdapterPath argument multiple times code.

@smadala
Copy link
Contributor Author

smadala commented Dec 5, 2017

From @NikolayPianikov on November 18, 2017 14:23

@smadala yes, but I used it under dotnet test or msbuild /t:vstest. Error is specified in the 'TestAdapterPath' is invalid. Error: The given path's format is not supported.
Exception is here

@smadala
Copy link
Contributor Author

smadala commented Dec 5, 2017

From @dtretyakov on December 5, 2017 12:40

@smadala, in VSTestTask, which is shipped with .net core sdk, allowed only one argument for VSTestTestAdapterPath and it's is bypassed into vstest console as a single argument:

And it's blocking use case in our integration, see JetBrains/teamcity-dotnet-plugin#101

When do you plan to fix it?

@smadala
Copy link
Contributor Author

smadala commented Dec 5, 2017

@NikolayPianikov @dtretyakov Feel free to raise PR. Let us know if you need any help.
/cc @pvlakshm for triage.

@dtretyakov
Copy link
Contributor

@smadala, it was also mentioned in #141 (comment) by @AbhitejJohn that:

the commandline testadapterpath argument does not take in multiple paths which is another gap.

@dtretyakov
Copy link
Contributor

@smadala, please take a look at the following PR: #1320

dtretyakov added a commit to dtretyakov/vstest that referenced this issue Dec 6, 2017
@smadala
Copy link
Contributor Author

smadala commented Dec 6, 2017

  • This issue need to address handling multiple values in VSTestTask for applicable parameters.
  • Should have same adapter picking up logic for both .NET Core & .NET Full?
    /cc thoughts @singhsarab @pvlakshm @mayankbansal018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants