Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide an IsUnicode API #3420

Closed
rowanmiller opened this issue Oct 13, 2015 · 4 comments
Closed

Provide an IsUnicode API #3420

rowanmiller opened this issue Oct 13, 2015 · 4 comments
Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Milestone

Comments

@rowanmiller
Copy link
Contributor

As pointed out in #3362 we have removed this API which forces you to specify a provider specific type in cases where you would not have needed to in EF6. We should add this into EF7.

@joshmouch
Copy link

I think IsFixedLength() is probably the other one that is agnostic yet can have an easy fallback if not supported by the provider. I use that because I override the entities in Microsoft Identity 2.0, and it uses that quite a bit.

@bricelam
Copy link
Contributor

bricelam commented Nov 6, 2015

Note to implementer: Don't forget to diff the metadata in MigrationsModelDiffer.Diff(IProperty, IProperty).

@lajones
Copy link
Contributor

lajones commented Jan 28, 2016

Note to implementer: when we do this we'll need to update scaffolding to output IsUnicode(false) for varchar columns instead of outputting HasColumnType("varchar(x)") as we do now. See discussion in #4312.

@divega
Copy link
Contributor

divega commented May 11, 2016

Cleaning up milestone so that we can see this in triage.

@rowanmiller rowanmiller added this to the 1.0.1 milestone May 13, 2016
@ajcvickers ajcvickers self-assigned this Jun 24, 2016
ajcvickers added a commit that referenced this issue Jun 28, 2016
Issue #3420

I think everything in the runtime and migrations areas is implemented. The ScaffoldingTypeMapper already supports unicode, but scaffolding will not make use of this until updated as described in issue #5410.
ajcvickers added a commit that referenced this issue Jun 29, 2016
Issue #3420

I think everything in the runtime and migrations areas is implemented. The ScaffoldingTypeMapper already supports unicode, but scaffolding will not make use of this until updated as described in issue #5410.
@ajcvickers ajcvickers added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Jul 6, 2016
@ajcvickers ajcvickers modified the milestones: 1.1.0-preview1, 1.1.0 Oct 15, 2022
@ajcvickers ajcvickers removed their assignment Sep 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Projects
None yet
Development

No branches or pull requests

6 participants