Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update scaffolding to use ScaffoldingTypeMapper #5410

Closed
ajcvickers opened this issue May 18, 2016 · 12 comments
Closed

Update scaffolding to use ScaffoldingTypeMapper #5410

ajcvickers opened this issue May 18, 2016 · 12 comments
Assignees
Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-bug
Milestone

Comments

@ajcvickers
Copy link
Member

This follows the changes made for #4425 which provides more information from the type mapper to scaffolding on what to scaffold for a given property. However, the implementation assumes that IsUnicode has been implemented and so this cannot be done until that issue is fixed--see #3420.

@rowanmiller rowanmiller added this to the 1.0.1 milestone May 23, 2016
ajcvickers added a commit that referenced this issue Jun 28, 2016
Issue #3420

I think everything in the runtime and migrations areas is implemented. The ScaffoldingTypeMapper already supports unicode, but scaffolding will not make use of this until updated as described in issue #5410.
ajcvickers added a commit that referenced this issue Jun 29, 2016
Issue #3420

I think everything in the runtime and migrations areas is implemented. The ScaffoldingTypeMapper already supports unicode, but scaffolding will not make use of this until updated as described in issue #5410.
@rowanmiller
Copy link
Contributor

rowanmiller commented Sep 21, 2016

When this is done, verify that decimal and numeric columns have scale/precision included in column type

@bricelam
Copy link
Contributor

This work was also mentioned as part of #1671

@AndriySvyryd
Copy link
Member

The type for decimal properties should always be specified, even if same as default, due to #6944

@lajones lajones removed this from the 2.0.0 milestone May 15, 2017
@ajcvickers
Copy link
Member Author

@lajones Can you elaborate on why this is flagged as a breaking change?

@lajones
Copy link
Contributor

lajones commented May 16, 2017

@ajcvickers This is part of the overall type mapping work. Though I haven't mapped out the exact API on how that will work yet, I don't think we'll manage to get through all of that without changing any of the type-mapping API. I don't know that it will specifically affect the ScaffoldingTypeMapper yet - we'll see.

@ajcvickers
Copy link
Member Author

@lajones So you are saying that using the ScaffoldingTypeMapper will affect the reverse engineering API such that it will be breaking for providers? Or that #7434 will do that, and this is part of the work needed for #7434?

@lajones
Copy link
Contributor

lajones commented May 16, 2017

@ajcvickers The latter. I'm saying #7434 may affect the APIs on ScaffoldingTypeMapper.

@ajcvickers
Copy link
Member Author

@lajones Then I think it's okay to have only #7434 marked as breaking.

@ajcvickers
Copy link
Member Author

Moving this out of preview2 since it doesn't need to be done.

@smitpatel smitpatel assigned smitpatel and unassigned lajones May 26, 2017
@smitpatel
Copy link
Member

smitpatel commented May 26, 2017

Poaching this as it is needed for #7004

@smitpatel
Copy link
Member

Fixed in #8626 & #8660
There are some inaccuracies in how it is used filed #8697

@smitpatel smitpatel modified the milestones: 2.0.0-preview2, 2.0.0 Jun 2, 2017
@smitpatel smitpatel added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Jun 2, 2017
@smitpatel
Copy link
Member

Commits 263c102 & 58c8f81

@ajcvickers ajcvickers modified the milestones: 2.0.0-preview2, 2.0.0 Oct 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-bug
Projects
None yet
Development

No branches or pull requests

6 participants