Implement IsUnicode API #5890
Merged
Implement IsUnicode API #5890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| /// </summary> | ||
| /// <param name="property"> The property to set the value for. </param> | ||
| /// <param name="unicode"> True if the property accepts unicode characters, false if it does not, null to clear the setting. </param> | ||
| public static void IsUnicode([NotNull] this IMutableProperty property, bool? unicode) |
There was a problem hiding this comment.
If it's first-class on the builder API, why not make it first-class on the Metadata API as well?
There was a problem hiding this comment.
Because we decided that for facets like this and max length we would make them annotations accessed by extension methods.
There was a problem hiding this comment.
I think we decided this mainly to keep the metadata interfaces minimal.
|
|
|
@rowanmiller Merged this, but would still appreciate you taking a look. |
|
Yep looks good to me |
| .ValueGeneratedOnAdd(); | ||
|
|
||
| b.Property<string>(""Name"") | ||
| .HasAnnotation(""Unicode"", false); |
There was a problem hiding this comment.
Should this be "lifted" to a Fluent API call? We do it for other relational configuration.
There was a problem hiding this comment.
@bricelam Good point. I'll do that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #3420
I think everything in the runtime and migrations areas is implemented. The ScaffoldingTypeMapper already supports unicode, but scaffolding will not make use of this until updated as described in issue #5410.
/cc @rowanmiller Can you look at the public API and doc comments?