Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added default dotnet-tools + additional tasks to launch them #16409

Merged
merged 3 commits into from
Dec 11, 2023
Merged

Added default dotnet-tools + additional tasks to launch them #16409

merged 3 commits into from
Dec 11, 2023

Conversation

vzarytovskii
Copy link
Member

@vzarytovskii vzarytovskii commented Dec 7, 2023 •
edited
Loading

Added tools I use the most. Now I need to manually install them in dev container every time, this will allow installing them in one command.

Also, added a task to launch fsi/fsc under trace, so it can be opened with speedscope later.

@vzarytovskii vzarytovskii requested a review from a team as a code owner December 7, 2023 16:25
baronfel
baronfel reviewed Dec 7, 2023
View reviewed changes
.config/dotnet-tools.json Show resolved Hide resolved
.vscode/tasks.json Show resolved Hide resolved
psfinaki
psfinaki reviewed Dec 8, 2023
View reviewed changes
Copy link
Member

@psfinaki psfinaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks useful - how about we mention some of those tasks in the DEVGUIDE?

.vscode/launch.json Show resolved Hide resolved
@vzarytovskii
Copy link
Member Author

vzarytovskii commented Dec 8, 2023 •
edited
Loading

This looks useful - how about we mention some of those tasks in the DEVGUIDE?

Probably not worth it? These are standard tools/tasks, you either use them or don't. I feel like all of them are self explanatory?

We don't mention how to launch with VS diagnostic tools or dotTrace/dotMemory/windbg there.

@psfinaki
Copy link
Member

psfinaki commented Dec 8, 2023

Probably not worth it? These are standard tools/tasks, you either use them or don't. I feel like all of them are self explanatory?
We don't mention how to launch with VS diagnostic tools or dotTrace/dotMemory/windbg there.

Mmm e.g. we have that note about updating XLFs and it says "This can be done automatically by running this command" and I just thought we could add smth like "... or by executing this task in VSCode". So that people have a notion of those.

I personally don't use VSCode tasks so I don't know - but now looking at the PR I am thinking it is easy enough to give them a try and change my dev routines.

Up to you ofc.

@vzarytovskii
Copy link
Member Author

Probably not worth it? These are standard tools/tasks, you either use them or don't. I feel like all of them are self explanatory?
We don't mention how to launch with VS diagnostic tools or dotTrace/dotMemory/windbg there.

Mmm e.g. we have that note about updating XLFs and it says "This can be done automatically by running this command" and I just thought we could add smth like "... or by executing this task in VSCode". So that people have a notion of those.

I personally don't use VSCode tasks so I don't know - but now looking at the PR I am thinking it is easy enough to give them a try and change my dev routines.

Up to you ofc.

I wouldn't update them just for now. Since our VSCode support is not great at the moment. I'd update it and fully add once we do more LSP testing, I think.

@abonie abonie merged commit f503ae9 into dotnet:main Dec 11, 2023
26 checks passed
@allisonchou allisonchou mentioned this pull request Dec 15, 2023
Closed
OwnageIsMagic added a commit to OwnageIsMagic/fsharp that referenced this pull request Dec 21, 2023
@OwnageIsMagic
Merge remote-tracking branch 'upstream/main'
9246ac8 
* upstream/main: (166 commits)
  typo in foldBack summary (dotnet#16453)
  Fix for dotnet#83 (improve constraint error message) (dotnet#16304)
  Name resolution: resolve interfaces in expressions (dotnet#15660)
  AddExplicitReturnType refactoring (dotnet#16077)
  Disabling 2 tests: running for too long, causing CI timeouts
  Improve value restriction error message dotnet#1103 (dotnet#15877)
  Parens: Keep parens for non-identical infix operator pairs with same precedence (dotnet#16372)
  More release note entries (dotnet#16438)
  Using Ordinal is both faster and more correct as our intent is to do … (dotnet#16439)
  merge (dotnet#16427)
  Optimize empty string compares (dotnet#16435)
  Checker: recover on unresolved type in 'inherit' member (dotnet#16429)
  Release notes proposal (dotnet#16377)
  [main] Update dependencies from dotnet/source-build-reference-packages (dotnet#16411)
  Allow usage of [<TailCall>] with older FSharp.Core package versions (dotnet#16373)
  Parser: recover on unfinished 'as' patterns (dotnet#16404)
  Parens: Keep parens in method calls in dot-lambdas (dotnet#16395)
  Checker: check unfinished obj expression inside computations (dotnet#16413)
  Added default dotnet-tools + additional tasks to launch them (dotnet#16409)
  make `remarks` and `returns` visible in quick info (dotnet#16417)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baronfel baronfel baronfel left review comments

@psfinaki psfinaki psfinaki approved these changes

@abonie abonie abonie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vzarytovskii @psfinaki @baronfel @abonie