make remarks and returns visible in quick info
#16417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dotnet-policy-service agree |
vsintegration/src/FSharp.Editor/DocComments/XMLDocumentation.fs
Outdated
Show resolved
Hide resolved
vsintegration/src/FSharp.Editor/DocComments/XMLDocumentation.fs
Outdated
Show resolved
Hide resolved
add an option to control visibility of `remarks`
|
new line was added adds between sections, and an new options was added to control visibility of |
T-Gro
approved these changes
Dec 11, 2023
psfinaki
approved these changes
Dec 11, 2023
There was a problem hiding this comment.
Thanks a bunch for this. And great to see that someone is testing VS localization :)
@majocha @brianrourkeboll @baronfel thanks for your inputs here as well!
OwnageIsMagic
added a commit
to OwnageIsMagic/fsharp
that referenced
this pull request
Dec 21, 2023
* upstream/main: (166 commits) typo in foldBack summary (dotnet#16453) Fix for dotnet#83 (improve constraint error message) (dotnet#16304) Name resolution: resolve interfaces in expressions (dotnet#15660) AddExplicitReturnType refactoring (dotnet#16077) Disabling 2 tests: running for too long, causing CI timeouts Improve value restriction error message dotnet#1103 (dotnet#15877) Parens: Keep parens for non-identical infix operator pairs with same precedence (dotnet#16372) More release note entries (dotnet#16438) Using Ordinal is both faster and more correct as our intent is to do … (dotnet#16439) merge (dotnet#16427) Optimize empty string compares (dotnet#16435) Checker: recover on unresolved type in 'inherit' member (dotnet#16429) Release notes proposal (dotnet#16377) [main] Update dependencies from dotnet/source-build-reference-packages (dotnet#16411) Allow usage of [<TailCall>] with older FSharp.Core package versions (dotnet#16373) Parser: recover on unfinished 'as' patterns (dotnet#16404) Parens: Keep parens in method calls in dot-lambdas (dotnet#16395) Checker: check unfinished obj expression inside computations (dotnet#16413) Added default dotnet-tools + additional tasks to launch them (dotnet#16409) make `remarks` and `returns` visible in quick info (dotnet#16417) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Make
remarksandreturnsparts of xml documentation visible in quick info.And fix a bug that no xml doc was showed when
let ok, idx = index.ParseMemberSignaturereturnok = 0, idx = 0Showing
returnsparts can let user know more about to the function's return value (especially when it returns named tuples from C#)Showing
remarksparts can let user know more about to the functionChecklist
Test cases added
Performance benchmarks added in case of performance changes
Release notes entry updated: