Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

typo in foldBack summary #16453

Merged
merged 1 commit into from
Dec 20, 2023
Merged

typo in foldBack summary #16453

merged 1 commit into from
Dec 20, 2023

Conversation

fajpunk
Copy link
Contributor

@fajpunk fajpunk commented Dec 20, 2023

Description

The foldBack function is mistakenly called fold in the <summary> tag

Checklist

  • [n/a ] Test cases added
  • [n/a ] Performance benchmarks added in case of performance changes
  • [n/a ] Release notes entry updated

@fajpunk fajpunk requested a review from a team as a code owner December 20, 2023 02:35
psfinaki
psfinaki approved these changes Dec 20, 2023
View reviewed changes
Copy link
Member

@psfinaki psfinaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Dan.

@psfinaki psfinaki enabled auto-merge (squash) December 20, 2023 11:27
@vzarytovskii
Copy link
Member

vzarytovskii commented Dec 20, 2023 •
edited
Loading

Thanks! I wonder if we somehow can utilise fantomas (or its libraries) to check whether if the changes are in docs, and don't run full CI suite? We do it already for markdown changes.

@psfinaki psfinaki merged commit 99514c0 into dotnet:main Dec 20, 2023
26 checks passed
OwnageIsMagic added a commit to OwnageIsMagic/fsharp that referenced this pull request Dec 21, 2023
@OwnageIsMagic
Merge remote-tracking branch 'upstream/main'
9246ac8 
* upstream/main: (166 commits)
  typo in foldBack summary (dotnet#16453)
  Fix for dotnet#83 (improve constraint error message) (dotnet#16304)
  Name resolution: resolve interfaces in expressions (dotnet#15660)
  AddExplicitReturnType refactoring (dotnet#16077)
  Disabling 2 tests: running for too long, causing CI timeouts
  Improve value restriction error message dotnet#1103 (dotnet#15877)
  Parens: Keep parens for non-identical infix operator pairs with same precedence (dotnet#16372)
  More release note entries (dotnet#16438)
  Using Ordinal is both faster and more correct as our intent is to do … (dotnet#16439)
  merge (dotnet#16427)
  Optimize empty string compares (dotnet#16435)
  Checker: recover on unresolved type in 'inherit' member (dotnet#16429)
  Release notes proposal (dotnet#16377)
  [main] Update dependencies from dotnet/source-build-reference-packages (dotnet#16411)
  Allow usage of [<TailCall>] with older FSharp.Core package versions (dotnet#16373)
  Parser: recover on unfinished 'as' patterns (dotnet#16404)
  Parens: Keep parens in method calls in dot-lambdas (dotnet#16395)
  Checker: check unfinished obj expression inside computations (dotnet#16413)
  Added default dotnet-tools + additional tasks to launch them (dotnet#16409)
  make `remarks` and `returns` visible in quick info (dotnet#16417)
  ...
@OwnageIsMagic OwnageIsMagic mentioned this pull request Dec 22, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vzarytovskii vzarytovskii vzarytovskii approved these changes

@psfinaki psfinaki psfinaki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
F# Compiler and Tooling
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fajpunk @vzarytovskii @psfinaki