Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[java-agent] disable java-attacher tab #122164

Merged
merged 4 commits into from
Jan 5, 2022

Conversation

stuartnelson3
Copy link
Contributor

Summary

The apm-server doesn't have the permissions to
fork/exec the java-attacher process, so this tab
cannot currently work. Hiding it from users seems
like the prudent choice while a workaround is
discovered.

For maintainers

The apm-server doesn't have the permissions to
fork/exec the java-attacher process, so this tab
cannot currently work. Hiding it from users seems
like the prudent choice while a workaround is
discovered.
@stuartnelson3 stuartnelson3 requested review from ogupte, felixbarny and a team December 30, 2021 11:05
@botelastic botelastic bot added the Team:APM All issues that need APM UI Team support label Dec 30, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@marclop
Copy link

marclop commented Jan 4, 2022

@elasticmachine merge upstream

Copy link

@marclop marclop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@felixbarny
Copy link
Member

felixbarny commented Jan 4, 2022 via email

@marclop
Copy link

marclop commented Jan 4, 2022

@felixbarny currently, the APM Server process lacks the appropriate capabilities to run fork/exec anywhere it is managed by the Elastic Agent. This means that the attacher only works in the unsupported standalone mode.

Also, we've disallowed running the attacher in the APM Server code if it's running in ESS.

@@ -55,7 +54,6 @@ export const ApmAgentInstructionsMappings: Array<{
title: 'Java',
variantId: 'java',
createAgentInstructions: createJavaAgentInstructions,
AgentRuntimeAttachment: JavaRuntimeAttachment,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may want to just comment with a // TODO to add it back

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's totally fine, if you prefer. I deleted it because it's in git.

@ogupte ogupte added auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes and removed release_note:fix labels Jan 5, 2022
@stuartnelson3 stuartnelson3 enabled auto-merge (squash) January 5, 2022 15:01
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
apm 1218 1177 -41

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 3.0MB 2.8MB -207.5KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@stuartnelson3 stuartnelson3 merged commit c52d9f3 into elastic:main Jan 5, 2022
@kibanamachine
Copy link
Contributor

The following labels were identified as gaps in your version labels and will be added automatically:

  • v8.1.0

If any of these should not be on your pull request, please manually remove them.

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jan 5, 2022
* [java-agent] disable java-attacher tab

The apm-server doesn't have the permissions to
fork/exec the java-attacher process, so this tab
cannot currently work. Hiding it from users seems
like the prudent choice while a workaround is
discovered.
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
8.0

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Jan 5, 2022
* [java-agent] disable java-attacher tab

The apm-server doesn't have the permissions to
fork/exec the java-attacher process, so this tab
cannot currently work. Hiding it from users seems
like the prudent choice while a workaround is
discovered.

Co-authored-by: stuart nelson <stuartnelson3@gmail.com>
@stuartnelson3 stuartnelson3 deleted the disable-java-attacher-tab branch January 6, 2022 08:28
gbamparop pushed a commit to gbamparop/kibana that referenced this pull request Jan 12, 2022
* [java-agent] disable java-attacher tab

The apm-server doesn't have the permissions to
fork/exec the java-attacher process, so this tab
cannot currently work. Hiding it from users seems
like the prudent choice while a workaround is
discovered.