-
Notifications
You must be signed in to change notification settings - Fork 8.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[java-agent] disable java-attacher tab #122164
[java-agent] disable java-attacher tab #122164
Conversation
The apm-server doesn't have the permissions to fork/exec the java-attacher process, so this tab cannot currently work. Hiding it from users seems like the prudent choice while a workaround is discovered.
Pinging @elastic/apm-ui (Team:apm) |
@elasticmachine merge upstream |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
apm-server doesn't have the permissions to fork/exec the java-attacher
process
What are the scenarios in which permissions are lacking? Are there
scenarios in which forking the attacher process is working?
If it's just the scenario where the cloud-hosted APM Server can't fork a
process I don't think that's an issue. That's because the tab won't be
shown for cloud/managed policies.
After all, the container in which the APM Server runs on cloud does not
contain any Java processes that a user would want to attach the java agent
to.
The Java attacher tab is only relevant (and should only be displayed) for
on prem policies. Because we can only do attachment if Elastic Agent/APM
Server runs on the same host as the user's Java applications.
cc @eyalkoren
…On Thu, Dec 30, 2021 at 2:33 PM kibana-ci ***@***.***> wrote:
💚 Build Succeeded
- Buildkite Build
<https://buildkite.com/elastic/kibana-pull-request/builds/15424>
- Commit: f629517
<f629517>
- Storybooks Preview
<https://ci-artifacts.kibana.dev/storybooks/pr-122164/f62951705c3cf37aed85a278dfee73ff04ed52f1>
Metrics [docs
<https://www.elastic.co/guide/en/kibana/master/ci-metrics.html>] Module
Count
Fewer modules leads to a faster build time
id before
<cf81ece>
after
<f629517>
diff
apm 1218 1177 -41 Async chunks
Total size of all lazy-loaded chunks that will be downloaded as the user
navigates the app
id before
<cf81ece>
after
<f629517>
diff
apm 3.0MB 2.8MB -207.5KB History
- 💔 Build #15416
<https://buildkite.com/elastic/kibana-pull-request/builds/15416>
failed d12febc
<d12febc>
To update your PR or re-run it, just comment with:
@elasticmachine merge upstream
—
Reply to this email directly, view it on GitHub
<#122164 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAQQGCBHE7USMXGFDWXXX5LUTRNSBANCNFSM5K7QZEEQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
@felixbarny currently, the APM Server process lacks the appropriate capabilities to run Also, we've disallowed running the attacher in the APM Server code if it's running in ESS. |
@@ -55,7 +54,6 @@ export const ApmAgentInstructionsMappings: Array<{ | |||
title: 'Java', | |||
variantId: 'java', | |||
createAgentInstructions: createJavaAgentInstructions, | |||
AgentRuntimeAttachment: JavaRuntimeAttachment, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We may want to just comment with a // TODO
to add it back
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's totally fine, if you prefer. I deleted it because it's in git.
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
History
To update your PR or re-run it, just comment with: |
The following labels were identified as gaps in your version labels and will be added automatically:
If any of these should not be on your pull request, please manually remove them. |
* [java-agent] disable java-attacher tab The apm-server doesn't have the permissions to fork/exec the java-attacher process, so this tab cannot currently work. Hiding it from users seems like the prudent choice while a workaround is discovered.
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
* [java-agent] disable java-attacher tab The apm-server doesn't have the permissions to fork/exec the java-attacher process, so this tab cannot currently work. Hiding it from users seems like the prudent choice while a workaround is discovered. Co-authored-by: stuart nelson <stuartnelson3@gmail.com>
* [java-agent] disable java-attacher tab The apm-server doesn't have the permissions to fork/exec the java-attacher process, so this tab cannot currently work. Hiding it from users seems like the prudent choice while a workaround is discovered.
Summary
The apm-server doesn't have the permissions to
fork/exec the java-attacher process, so this tab
cannot currently work. Hiding it from users seems
like the prudent choice while a workaround is
discovered.
For maintainers