[Auth] Phone Auth – Fallback to reCATCHA flow when "invalid app credential" error is thrown #13519

ncooke3 · 2024-08-19T18:58:05Z

This is one step towards fixing #13479.

There are two parts to fix for that issue:

why invalid app credential is being returned
how SDK responds to it

After testing 10.29.0, I can only reproduce the issue on 11.0.0. This PR addresses the second point– how the SDK responds to the error.

Based on the 11.0.0 code comment (see diff) and 10.29.0 code (see below snippet), reCAPTCHA should launch for a missing app token or invalid app credential.

firebase-ios-sdk/FirebaseAuth/Sources/AuthProvider/Phone/FIRPhoneAuthProvider.m

Lines 628 to 630 in eca84fd

    
           BOOL isInvalidAppCredential = 
        
               error.code == FIRAuthErrorCodeInternalError && 
        
               underlyingError.code == FIRAuthErrorCodeInvalidAppCredential;

The issue is that the v11 parsing logic was expecting the invalid app credential to be an internal error, but it is not wrapped as such, so the control flow never enters the conditional and calls into reCAPTCHA.

firebase-ios-sdk/FirebaseAuth/Sources/Swift/Utilities/AuthErrorUtils.swift

Line 95 in 9118aca

return error(code: SharedErrorCode.public(code), userInfo: userInfo)

Looking back at the 10.29.0 code, I think it's possible this was a bug there too where invalid app credential is also a public error. But, at least from my testing, I'm not seeing the server return "invalid app credential" on 10.29.0.

firebase-ios-sdk/FirebaseAuth/Sources/Utilities/FIRAuthErrorUtils.m

Line 1032 in eca84fd

    
           BOOL isPublic = (code & FIRAuthPublicErrorCodeFlag) == FIRAuthPublicErrorCodeFlag;

firebase-ios-sdk/FirebaseAuth/Sources/Utilities/FIRAuthInternalErrors.h

Lines 306 to 309 in eca84fd

    
             /** Indicates that an invalid APNS device token was used in the verifyClient request. 
        
              */ 
        
             FIRAuthInternalErrorCodeInvalidAppCredential = FIRAuthPublicErrorCodeFlag | 
        
                                                            FIRAuthErrorCodeInvalidAppCredential,

This PR should add a fallback to reCAPTCHA to address behavior.

#no-changelog

…TCHA flow

….2.0" (#1228) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [firebase/firebase-ios-sdk](https://redirect.github.com/firebase/firebase-ios-sdk) | minor | `from: "11.1.0"` -> `from: "11.2.0"` | --- ### Release Notes <details> <summary>firebase/firebase-ios-sdk (firebase/firebase-ios-sdk)</summary> ### [`v11.2.0`](https://redirect.github.com/firebase/firebase-ios-sdk/releases/tag/11.2.0): Firebase Apple 11.2.0 [Compare Source](https://redirect.github.com/firebase/firebase-ios-sdk/compare/11.1.0...11.2.0) The Firebase Apple SDK (11.2.0) is now available. For more details, see the [Firebase Apple SDK release notes.](https://firebase.google.com/support/release-notes/ios#11.2.0) To install this SDK, see [Add Firebase to your project](https://firebase.google.com/docs/ios/setup). #### What's Changed - \[Auth] Phone Auth – Fallback to reCATCHA flow when "invalid app credential" error is thrown by [@ncooke3](https://redirect.github.com/ncooke3) in [firebase/firebase-ios-sdk#13519 - \[Auth] Fix Xcode 16 continuation crashes by [@paulb777](https://redirect.github.com/paulb777) in [firebase/firebase-ios-sdk#13521 - \[Auth] Fix Phone Auth via APNS for Sandbox Tokens and update Sample's Firebase app by [@paulb777](https://redirect.github.com/paulb777) in [firebase/firebase-ios-sdk#13539 - \[Auth] Add background modes capability to plist by [@ncooke3](https://redirect.github.com/ncooke3) in [firebase/firebase-ios-sdk#13548 - \[Auth] When swizzling is disabled, open URLs via SceneDelegate by [@ncooke3](https://redirect.github.com/ncooke3) in [firebase/firebase-ios-sdk#13557 - \[Auth] Fix unexpected nil in fetchSignInMethods success case by [@ncooke3](https://redirect.github.com/ncooke3) in [firebase/firebase-ios-sdk#13561 - \[Auth] Fix user session persistence in multi tenant projects by [@paulb777](https://redirect.github.com/paulb777) in [firebase/firebase-ios-sdk#13567 - \[Crashlytics] Fix Firebase/Crashlytics min iOS version by [@paulb777](https://redirect.github.com/paulb777) in [firebase/firebase-ios-sdk#13580 - \[Database] Fix temporary disconnect when app goes inactive by [@paulb777](https://redirect.github.com/paulb777) in [firebase/firebase-ios-sdk#13564 - \[Firestore] Mark readonly public classes as Sendable by [@paulb777](https://redirect.github.com/paulb777) in [firebase/firebase-ios-sdk#13453 - \[Firestore] Support hex strings to prevent broken log lines by [@ls-todd-lunter](https://redirect.github.com/ls-todd-lunter) in [firebase/firebase-ios-sdk#13128 - \[Functions] `FunctionsContext` Updates by [@yakovmanshin](https://redirect.github.com/yakovmanshin) in [firebase/firebase-ios-sdk#13531 - \[Functions] Updated Functions Errors by [@yakovmanshin](https://redirect.github.com/yakovmanshin) in [firebase/firebase-ios-sdk#13535 - \[Testing] Update OCMock dependency to v3.9.4 by [@andrewheard](https://redirect.github.com/andrewheard) in [firebase/firebase-ios-sdk#13536 - \[Vertex AI] Make `uri` optional in `Citation` and add `title` field by [@andrewheard](https://redirect.github.com/andrewheard) in [firebase/firebase-ios-sdk#13520 - \[Vertex AI] Add `Sendable` conformance to types by [@andrewheard](https://redirect.github.com/andrewheard) in [firebase/firebase-ios-sdk#13560 - \[Vertex AI] Make `Logger` properties constants by [@andrewheard](https://redirect.github.com/andrewheard) in [firebase/firebase-ios-sdk#13570 - \[Vertex AI] Make `GenerativeModel` and `Chat` into Swift actors by [@andrewheard](https://redirect.github.com/andrewheard) in [firebase/firebase-ios-sdk#13545 - \[Vertex AI] Make generateContentStream/sendMessageStream throws by [@andrewheard](https://redirect.github.com/andrewheard) in [firebase/firebase-ios-sdk#13573 - \[Vertex AI] Add `SourceImage` enum to `ImageConversionError` by [@andrewheard](https://redirect.github.com/andrewheard) in [firebase/firebase-ios-sdk#13575 - \[Vertex AI] Add `responseSchema` to `GenerationConfig` by [@andrewheard](https://redirect.github.com/andrewheard) in [firebase/firebase-ios-sdk#13576 #### New Contributors - [@ls-todd-lunter](https://redirect.github.com/ls-todd-lunter) made their first contribution in [firebase/firebase-ios-sdk#13128 **Full Changelog**: firebase/firebase-ios-sdk@11.1.0...11.2.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://redirect.github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://redirect.github.com/renovatebot/renovate).  Co-authored-by: cgrindel-self-hosted-renovate[bot] <139595543+cgrindel-self-hosted-renovate[bot]@users.noreply.github.com> Co-authored-by: Chuck Grindel <chuck.grindel@gmail.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

[Auth] Fix v11 phone auth regression that prevented fallback to reCAP…

7e1dc56

…TCHA flow

google-oss-bot added the api: auth label Aug 19, 2024

ncooke3 changed the title ~~[Auth] Fix v11 phone auth regression that prevented fallback to reCATCHA flow~~ [Auth] Fallback to reCATCHA flow when "invalid app credential" error is thrown Aug 19, 2024

ncooke3 changed the title ~~[Auth] Fallback to reCATCHA flow when "invalid app credential" error is thrown~~ [Auth] Fall back to reCATCHA flow when "invalid app credential" error is thrown Aug 19, 2024

ncooke3 changed the title ~~[Auth] Fall back to reCATCHA flow when "invalid app credential" error is thrown~~ [Auth] Phone Auth – Fallback to reCATCHA flow when "invalid app credential" error is thrown Aug 19, 2024

ncooke3 marked this pull request as ready for review August 19, 2024 19:30

paulb777 approved these changes Aug 19, 2024

View reviewed changes

ncooke3 merged commit c570e44 into main Aug 23, 2024
56 checks passed

ncooke3 deleted the nc/fix-phone-auth branch August 23, 2024 22:49

ncooke3 mentioned this pull request Aug 29, 2024

Phone Auth not working above iOS 16 #13479

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Auth] Phone Auth – Fallback to reCATCHA flow when "invalid app credential" error is thrown #13519

[Auth] Phone Auth – Fallback to reCATCHA flow when "invalid app credential" error is thrown #13519

ncooke3 commented Aug 19, 2024 •

edited

Loading

	BOOL isInvalidAppCredential =
	error.code == FIRAuthErrorCodeInternalError &&
	underlyingError.code == FIRAuthErrorCodeInvalidAppCredential;

	/** Indicates that an invalid APNS device token was used in the verifyClient request.
	*/
	FIRAuthInternalErrorCodeInvalidAppCredential = FIRAuthPublicErrorCodeFlag \|
	FIRAuthErrorCodeInvalidAppCredential,

[Auth] Phone Auth – Fallback to reCATCHA flow when "invalid app credential" error is thrown #13519

[Auth] Phone Auth – Fallback to reCATCHA flow when "invalid app credential" error is thrown #13519

Conversation

ncooke3 commented Aug 19, 2024 • edited Loading

ncooke3 commented Aug 19, 2024 •

edited

Loading