[Auth] Fix unexpected nil in fetchSignInMethods success case #13561

ncooke3 · 2024-08-31T00:49:10Z

Revert the URL to match Firebase 10 (

firebase-ios-sdk/FirebaseAuth/Sources/Auth/FIRAuth.m

Line 676 in eca84fd

continueURI:@"http://www.google.com/"

). This actually didn't make a difference and I was able to get valid sign in methods when using both forms. LMK if there is a reason to not change it back.
The below line lead to crash as response.signinMethods is nil so the continuation throws an implicitly unwrapped error which crashes.

firebase-ios-sdk/FirebaseAuth/Sources/Swift/Auth/Auth.swift

Line 298 in 486a0a0

Auth.wrapMainAsync(callback: completion, withParam: response.signinMethods, error: nil)
- This can be reproduced in a scenario where email enumeration protection is turned on. The unit test added will fail without the corresponding changes in CreateAuthURIResponse.swift

paulb777

Good find and thanks for adding the tests!

FirebaseAuth/Tests/SampleSwift/SwiftApiTests/EmailPasswordTests.swift

paulb777 · 2024-08-31T13:59:00Z

FirebaseAuth/Sources/Swift/Backend/RPC/CreateAuthURIResponse.swift

@@ -45,6 +45,6 @@ class CreateAuthURIResponse: AuthRPCResponse {
    registered = dictionary["registered"] as? Bool ?? false
    forExistingProvider = dictionary["forExistingProvider"] as? Bool ?? false
    allProviders = dictionary["allProviders"] as? [String]
-    signinMethods = dictionary["signinMethods"] as? [String]
+    signinMethods = dictionary["signinMethods"] as? [String] ?? []


It's technically an API change to return an empty array instead of nil, so worth calling out in the release notes.

I think this PR may actually be re-aligning the behavior with the API contract:

firebase-ios-sdk/FirebaseAuth/Sources/Swift/Auth/Auth.swift

Lines 279 to 281 in 486a0a0

/// - Parameter completion: Optionally; a block which is invoked when the list of sign in methods

/// for the specified email address is ready or an error was encountered. Invoked asynchronously

/// on the main thread in the future.

Specifically, the list of sign in methods for the specified email address is ready or an error was encountered part.

In the current behavior, (nil, nil) was being passed to the completion handler which caused the crash.

I will merge this now, but can address anything else post-merge.

Won't those using the callback version of the API now get [], nil instead of nil,nil

Yes, [], nil. I'm thinking that this is a valid combo as opposed to nil, nil.

Agreed, but it's possible there may be apps checking for nil,nil since it doesn't crash when using the callback api

True, ok I'll point this out in release notes.

One different approach to this PR is to preserve nil, nil as a valid combo and change the async wrapper to return a [String]? instead [String].

I think this PR with the corresponding release note is the better option.

Yes. I would suspect that in practice, code would just not exercise the nil case and just loop zero times iterating the empty list.

So unlikely anything will break if the release note gets missed

Done in d855c25

FirebaseAuth/Sources/Swift/Backend/RPC/CreateAuthURIResponse.swift

….2.0" (#1228) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [firebase/firebase-ios-sdk](https://redirect.github.com/firebase/firebase-ios-sdk) | minor | `from: "11.1.0"` -> `from: "11.2.0"` | --- ### Release Notes <details> <summary>firebase/firebase-ios-sdk (firebase/firebase-ios-sdk)</summary> ### [`v11.2.0`](https://redirect.github.com/firebase/firebase-ios-sdk/releases/tag/11.2.0): Firebase Apple 11.2.0 [Compare Source](https://redirect.github.com/firebase/firebase-ios-sdk/compare/11.1.0...11.2.0) The Firebase Apple SDK (11.2.0) is now available. For more details, see the [Firebase Apple SDK release notes.](https://firebase.google.com/support/release-notes/ios#11.2.0) To install this SDK, see [Add Firebase to your project](https://firebase.google.com/docs/ios/setup). #### What's Changed - \[Auth] Phone Auth – Fallback to reCATCHA flow when "invalid app credential" error is thrown by [@ncooke3](https://redirect.github.com/ncooke3) in [firebase/firebase-ios-sdk#13519 - \[Auth] Fix Xcode 16 continuation crashes by [@paulb777](https://redirect.github.com/paulb777) in [firebase/firebase-ios-sdk#13521 - \[Auth] Fix Phone Auth via APNS for Sandbox Tokens and update Sample's Firebase app by [@paulb777](https://redirect.github.com/paulb777) in [firebase/firebase-ios-sdk#13539 - \[Auth] Add background modes capability to plist by [@ncooke3](https://redirect.github.com/ncooke3) in [firebase/firebase-ios-sdk#13548 - \[Auth] When swizzling is disabled, open URLs via SceneDelegate by [@ncooke3](https://redirect.github.com/ncooke3) in [firebase/firebase-ios-sdk#13557 - \[Auth] Fix unexpected nil in fetchSignInMethods success case by [@ncooke3](https://redirect.github.com/ncooke3) in [firebase/firebase-ios-sdk#13561 - \[Auth] Fix user session persistence in multi tenant projects by [@paulb777](https://redirect.github.com/paulb777) in [firebase/firebase-ios-sdk#13567 - \[Crashlytics] Fix Firebase/Crashlytics min iOS version by [@paulb777](https://redirect.github.com/paulb777) in [firebase/firebase-ios-sdk#13580 - \[Database] Fix temporary disconnect when app goes inactive by [@paulb777](https://redirect.github.com/paulb777) in [firebase/firebase-ios-sdk#13564 - \[Firestore] Mark readonly public classes as Sendable by [@paulb777](https://redirect.github.com/paulb777) in [firebase/firebase-ios-sdk#13453 - \[Firestore] Support hex strings to prevent broken log lines by [@ls-todd-lunter](https://redirect.github.com/ls-todd-lunter) in [firebase/firebase-ios-sdk#13128 - \[Functions] `FunctionsContext` Updates by [@yakovmanshin](https://redirect.github.com/yakovmanshin) in [firebase/firebase-ios-sdk#13531 - \[Functions] Updated Functions Errors by [@yakovmanshin](https://redirect.github.com/yakovmanshin) in [firebase/firebase-ios-sdk#13535 - \[Testing] Update OCMock dependency to v3.9.4 by [@andrewheard](https://redirect.github.com/andrewheard) in [firebase/firebase-ios-sdk#13536 - \[Vertex AI] Make `uri` optional in `Citation` and add `title` field by [@andrewheard](https://redirect.github.com/andrewheard) in [firebase/firebase-ios-sdk#13520 - \[Vertex AI] Add `Sendable` conformance to types by [@andrewheard](https://redirect.github.com/andrewheard) in [firebase/firebase-ios-sdk#13560 - \[Vertex AI] Make `Logger` properties constants by [@andrewheard](https://redirect.github.com/andrewheard) in [firebase/firebase-ios-sdk#13570 - \[Vertex AI] Make `GenerativeModel` and `Chat` into Swift actors by [@andrewheard](https://redirect.github.com/andrewheard) in [firebase/firebase-ios-sdk#13545 - \[Vertex AI] Make generateContentStream/sendMessageStream throws by [@andrewheard](https://redirect.github.com/andrewheard) in [firebase/firebase-ios-sdk#13573 - \[Vertex AI] Add `SourceImage` enum to `ImageConversionError` by [@andrewheard](https://redirect.github.com/andrewheard) in [firebase/firebase-ios-sdk#13575 - \[Vertex AI] Add `responseSchema` to `GenerationConfig` by [@andrewheard](https://redirect.github.com/andrewheard) in [firebase/firebase-ios-sdk#13576 #### New Contributors - [@ls-todd-lunter](https://redirect.github.com/ls-todd-lunter) made their first contribution in [firebase/firebase-ios-sdk#13128 **Full Changelog**: firebase/firebase-ios-sdk@11.1.0...11.2.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://redirect.github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://redirect.github.com/renovatebot/renovate).  Co-authored-by: cgrindel-self-hosted-renovate[bot] <139595543+cgrindel-self-hosted-renovate[bot]@users.noreply.github.com> Co-authored-by: Chuck Grindel <chuck.grindel@gmail.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

ncooke3 added 2 commits August 30, 2024 20:40

[Auth] Fix unexpected nil in fetchSignInMethods success case

7d9b617

Add changelog

9dda4aa

google-oss-bot added the api: auth label Aug 31, 2024

ncooke3 added this to the 11.2.0 - M153 milestone Aug 31, 2024

paulb777 approved these changes Aug 31, 2024

View reviewed changes

ncooke3 and others added 3 commits August 31, 2024 17:08

[skip ci] Remove whitespace in comment

256a48b

[skip ci] Update comment in EmailPasswordTests.swift

9919971

review

d855c25

ncooke3 merged commit 853d83c into main Aug 31, 2024
56 checks passed

ncooke3 deleted the nc/fix13550 branch August 31, 2024 22:32

ncooke3 mentioned this pull request Aug 31, 2024

[Auth] Use result type to wrap completion handlers internally #13563

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Auth] Fix unexpected nil in fetchSignInMethods success case #13561

[Auth] Fix unexpected nil in fetchSignInMethods success case #13561

ncooke3 commented Aug 31, 2024 •

edited

Loading

paulb777 left a comment

paulb777 Aug 31, 2024

ncooke3 Aug 31, 2024 •

edited

Loading

ncooke3 Aug 31, 2024

paulb777 Aug 31, 2024

ncooke3 Aug 31, 2024

paulb777 Aug 31, 2024

ncooke3 Aug 31, 2024

paulb777 Aug 31, 2024

paulb777 Aug 31, 2024

ncooke3 Aug 31, 2024

	/// - Parameter completion: Optionally; a block which is invoked when the list of sign in methods
	/// for the specified email address is ready or an error was encountered. Invoked asynchronously
	/// on the main thread in the future.

[Auth] Fix unexpected nil in fetchSignInMethods success case #13561

[Auth] Fix unexpected nil in fetchSignInMethods success case #13561

Conversation

ncooke3 commented Aug 31, 2024 • edited Loading

paulb777 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ncooke3 Aug 31, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ncooke3 commented Aug 31, 2024 •

edited

Loading

ncooke3 Aug 31, 2024 •

edited

Loading