[Vertex AI] Make uri optional in Citation and add title field
#13520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewheard
commented
Aug 19, 2024
paulb777
approved these changes
Aug 19, 2024
@paulb777 We can try but I think the JS SDK's approach of following proto definition strictly (https://github.com/firebase/firebase-js-sdk/blob/05c34c91e61deb1c148ff1bc99333fc50e9e371f/packages/vertexai/src/types/responses.ts#L125-L131) is safest. |
mergify bot
added a commit
to cgrindel/rules_swift_package_manager
that referenced
this pull request
Sep 16, 2024
….2.0" (#1228) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [firebase/firebase-ios-sdk](https://redirect.github.com/firebase/firebase-ios-sdk) | minor | `from: "11.1.0"` -> `from: "11.2.0"` | --- ### Release Notes <details> <summary>firebase/firebase-ios-sdk (firebase/firebase-ios-sdk)</summary> ### [`v11.2.0`](https://redirect.github.com/firebase/firebase-ios-sdk/releases/tag/11.2.0): Firebase Apple 11.2.0 [Compare Source](https://redirect.github.com/firebase/firebase-ios-sdk/compare/11.1.0...11.2.0) The Firebase Apple SDK (11.2.0) is now available. For more details, see the [Firebase Apple SDK release notes.](https://firebase.google.com/support/release-notes/ios#11.2.0) To install this SDK, see [Add Firebase to your project](https://firebase.google.com/docs/ios/setup). #### What's Changed - \[Auth] Phone Auth – Fallback to reCATCHA flow when "invalid app credential" error is thrown by [@​ncooke3](https://redirect.github.com/ncooke3) in [firebase/firebase-ios-sdk#13519 - \[Auth] Fix Xcode 16 continuation crashes by [@​paulb777](https://redirect.github.com/paulb777) in [firebase/firebase-ios-sdk#13521 - \[Auth] Fix Phone Auth via APNS for Sandbox Tokens and update Sample's Firebase app by [@​paulb777](https://redirect.github.com/paulb777) in [firebase/firebase-ios-sdk#13539 - \[Auth] Add background modes capability to plist by [@​ncooke3](https://redirect.github.com/ncooke3) in [firebase/firebase-ios-sdk#13548 - \[Auth] When swizzling is disabled, open URLs via SceneDelegate by [@​ncooke3](https://redirect.github.com/ncooke3) in [firebase/firebase-ios-sdk#13557 - \[Auth] Fix unexpected nil in fetchSignInMethods success case by [@​ncooke3](https://redirect.github.com/ncooke3) in [firebase/firebase-ios-sdk#13561 - \[Auth] Fix user session persistence in multi tenant projects by [@​paulb777](https://redirect.github.com/paulb777) in [firebase/firebase-ios-sdk#13567 - \[Crashlytics] Fix Firebase/Crashlytics min iOS version by [@​paulb777](https://redirect.github.com/paulb777) in [firebase/firebase-ios-sdk#13580 - \[Database] Fix temporary disconnect when app goes inactive by [@​paulb777](https://redirect.github.com/paulb777) in [firebase/firebase-ios-sdk#13564 - \[Firestore] Mark readonly public classes as Sendable by [@​paulb777](https://redirect.github.com/paulb777) in [firebase/firebase-ios-sdk#13453 - \[Firestore] Support hex strings to prevent broken log lines by [@​ls-todd-lunter](https://redirect.github.com/ls-todd-lunter) in [firebase/firebase-ios-sdk#13128 - \[Functions] `FunctionsContext` Updates by [@​yakovmanshin](https://redirect.github.com/yakovmanshin) in [firebase/firebase-ios-sdk#13531 - \[Functions] Updated Functions Errors by [@​yakovmanshin](https://redirect.github.com/yakovmanshin) in [firebase/firebase-ios-sdk#13535 - \[Testing] Update OCMock dependency to v3.9.4 by [@​andrewheard](https://redirect.github.com/andrewheard) in [firebase/firebase-ios-sdk#13536 - \[Vertex AI] Make `uri` optional in `Citation` and add `title` field by [@​andrewheard](https://redirect.github.com/andrewheard) in [firebase/firebase-ios-sdk#13520 - \[Vertex AI] Add `Sendable` conformance to types by [@​andrewheard](https://redirect.github.com/andrewheard) in [firebase/firebase-ios-sdk#13560 - \[Vertex AI] Make `Logger` properties constants by [@​andrewheard](https://redirect.github.com/andrewheard) in [firebase/firebase-ios-sdk#13570 - \[Vertex AI] Make `GenerativeModel` and `Chat` into Swift actors by [@​andrewheard](https://redirect.github.com/andrewheard) in [firebase/firebase-ios-sdk#13545 - \[Vertex AI] Make generateContentStream/sendMessageStream throws by [@​andrewheard](https://redirect.github.com/andrewheard) in [firebase/firebase-ios-sdk#13573 - \[Vertex AI] Add `SourceImage` enum to `ImageConversionError` by [@​andrewheard](https://redirect.github.com/andrewheard) in [firebase/firebase-ios-sdk#13575 - \[Vertex AI] Add `responseSchema` to `GenerationConfig` by [@​andrewheard](https://redirect.github.com/andrewheard) in [firebase/firebase-ios-sdk#13576 #### New Contributors - [@​ls-todd-lunter](https://redirect.github.com/ls-todd-lunter) made their first contribution in [firebase/firebase-ios-sdk#13128 **Full Changelog**: firebase/firebase-ios-sdk@11.1.0...11.2.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://redirect.github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://redirect.github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC44MC4wIiwidXBkYXRlZEluVmVyIjoiMzguODAuMCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==--> Co-authored-by: cgrindel-self-hosted-renovate[bot] <139595543+cgrindel-self-hosted-renovate[bot]@users.noreply.github.com> Co-authored-by: Chuck Grindel <chuck.grindel@gmail.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added an optional
titlefield toCitation. Made theurifield optional since it may not be included when thetitleis provided. This resolves #13518.Sample files for tests updated in FirebaseExtended/vertexai-sdk-test-data#15.