Support for HCP Groups #787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Groups Data Source
* add groups data source * run go generate * remove redundant import name * add check for no inputs
* define group resource * group resource implementation * group resource test coverage * syntax, validation tweaks * add docs - group resource * add docs - group data source * revise schema constraints * cleanup docs/comments * add pre-destroy check to test coverage/update docs * create group before fetching in datasource test coverage
squaresurf
force-pushed
the
iam-groups-resources-hcpie-1016
branch
from
ca6b547
to
33fdfb0
Compare
seriousben
reviewed
Mar 15, 2024
seriousben
reviewed
Mar 15, 2024
seriousben
reviewed
Mar 15, 2024
seriousben
reviewed
Mar 15, 2024
itsjaspermilan
approved these changes
Mar 20, 2024
There was a problem hiding this comment.
Tested with a local version of the provider using the following terraform file:
terraform {
required_providers {
hcp = {
source = "localhost/providers/hcp"
version = "0.0.1"
}
}
}
provider "hcp" {}
data "hcp_user_principal" "me" {
user_id = <REDACTED_USER_ID>
}
resource "hcp_group" "cool-group" {
display_name = "Cool Group"
description = "Created with Terraform"
}
data "hcp_group" "another-cool-group" {
resource_name = <REDACTED_RESOURCE_NAME>
}
resource "hcp_group_members" "group-members-1" {
group = hcp_group.cool-group.resource_name
members = [
data.hcp_user_principal.me.user_id
]
}
resource "hcp_group_members" "group-members-2" {
group = data.hcp_group.another-cool-group.resource_name
members = [
data.hcp_user_principal.me.user_id
]
}
Before terraform apply
After terraform apply
manish-hashicorp
approved these changes
Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft Status
This PR is in a Draft status until we address a blocking bug with the way the Go client wants to use the Update Group API in IAM. See a more detailed write up here: https://docs.google.com/document/d/1iwKzeaQ9ENUmangKSLInPH0tUdqjs0QFpncuOPG4yXU/edit
🛠️ Description
To support TFC customers using terraform to configure their orgs, HCP requires some identity resources to be exposed in the HCP TF Provider like Groups, Group Memberships, Principal Datasource.
This PR adds the following:
🏗️ Acceptance tests
Output from acceptance testing:
This test is failing while we fix the IAM Update Group API
👀 Review Suggestions
Review of this PR would be easiest to review the changes as a whole rather than commit by commit. This is because there are multiple engineers working on this PR and we don't want to rewrite history out from each other. We will squash when it's time to merge.