feat: Update OTEL deps #52
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- upgrade @sentry/instrumentation to ^0.52.1 The main change that this brings in is https://github.com/open-telemetry/opentelemetry-js/releases/tag/experimental%2Fv0.52.1, which pins `import-in-the-middle` to have caret range. This allows users to get important bug fixes with `import-in-the-middle`. - upgrade @opentelemetry/semantic-conventions to ^1.25.1 This doesn't have any notable impact, but figured I'd upgrade it while I'm here
|
Hey @justindsmith, any chance to get this merged and released? FWIW we could even bump this to 0.53.0 now, which has been released in the meanwhile @AbhiPrasad |
mydea
added a commit
to getsentry/sentry-javascript
that referenced
this pull request
Sep 5, 2024
…13587) This bumps all our internal OTEL instrumentation to their latest version. Mainly, this fixes two things: * Mongoose now supports v7 & v8 open-telemetry/opentelemetry-js-contrib#2353 * A variety of bug fixes, including a problem with http.get in ESM mode open-telemetry/opentelemetry-js#4857 - See: https://github.com/open-telemetry/opentelemetry-js/releases/tag/experimental%2Fv0.53.0 Related: * open-telemetry/opentelemetry-js#4975 Issue about relaxing deps in "core" instrumentation packages * PR to bump deps in `@prisma/instrumentation`: prisma/prisma#25160 * PR to bump deps in `opentelemetry-instrument-remix`: justindsmith/opentelemetry-instrumentations-js#52 * PR to bump deps in `opentelemetry-instrumentation-fetch-node`: gas-buddy/opentelemetry-instrumentation-fetch-node#17 (which will also be superseded by #13485 eventually) * Closes #11499
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main change that this brings in is
https://github.com/open-telemetry/opentelemetry-js/releases/tag/experimental%2Fv0.52.1, which pins
import-in-the-middleto have caret range. This allows users to get important bug fixes withimport-in-the-middle. There are numerousimport-in-the-middlebugs that have been fixed, which is important for ESM users.This doesn't have any notable impact, but figured I'd upgrade it while I'm here