feat(instrumentation-mongoose): Support v7 and v8 #2353
Merged
+546
−269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2353 +/- ##
==========================================
- Coverage 90.97% 90.56% -0.42%
==========================================
Files 146 157 +11
Lines 7492 7631 +139
Branches 1502 1574 +72
==========================================
+ Hits 6816 6911 +95
- Misses 676 720 +44
|
onurtemizkan
force-pushed
the
mongoose-v7-v8
branch
7 times, most recently
from
a30b2d8
to
6075b12
Compare
onurtemizkan
force-pushed
the
mongoose-v7-v8
branch
from
6075b12
to
79ea242
Compare
|
@onurtemizkan I haven't reviewed this PR, yet. A side issue: I notice that you are force-pushing. If you are able, please don't force-push to a PR branch, at least not after there have been any reviews on it. It makes it harder to do subsequent re-reviews because it isn't clear what has changed from a previous commit. |
|
Thanks for looking into this @trentm, and yes I'll be careful not to force-push on reviewed code. FWIW these last couple were rebases on main. |
trentm
requested changes
Aug 8, 2024
There was a problem hiding this comment.
Thanks for the PR. This looks good, modulo a couple suggestions below.
Please also apply this change to the README.md:
diff --git a/plugins/node/instrumentation-mongoose/README.md b/plugins/node/instrumentation-mongoose/README.md
index c5500b14..31a19b4e 100644
--- a/plugins/node/instrumentation-mongoose/README.md
+++ b/plugins/node/instrumentation-mongoose/README.md
@@ -17,7 +17,7 @@ npm install --save @opentelemetry/instrumentation-mongoose
## Supported Versions
-- [`mongoose`](https://www.npmjs.com/package/mongoose) versions `>=5.9.7 <7`
+- [`mongoose`](https://www.npmjs.com/package/mongoose) versions `>=5.9.7 <9`
## Usage
plugins/node/instrumentation-mongoose/test/mongoose-v5-v6.test.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Trent Mick <trentm@gmail.com>
Co-authored-by: Trent Mick <trentm@gmail.com>
trentm
approved these changes
Aug 12, 2024
Merged
trentm
added a commit
to renovate-bot/opentelemetry-js-contrib
that referenced
this pull request
Aug 15, 2024
Note the warning about unhelpful npm behaviour in this workspace when the version of mongodb to test (by TAV) matches the version installed for the instrumentation-mongoose workspace. The version in instr-mongoose recently updated (in open-telemetry#2353), so it needs to update here as well.
mydea
added a commit
to getsentry/sentry-javascript
that referenced
this pull request
Sep 5, 2024
…13587) This bumps all our internal OTEL instrumentation to their latest version. Mainly, this fixes two things: * Mongoose now supports v7 & v8 open-telemetry/opentelemetry-js-contrib#2353 * A variety of bug fixes, including a problem with http.get in ESM mode open-telemetry/opentelemetry-js#4857 - See: https://github.com/open-telemetry/opentelemetry-js/releases/tag/experimental%2Fv0.53.0 Related: * open-telemetry/opentelemetry-js#4975 Issue about relaxing deps in "core" instrumentation packages * PR to bump deps in `@prisma/instrumentation`: prisma/prisma#25160 * PR to bump deps in `opentelemetry-instrument-remix`: justindsmith/opentelemetry-instrumentations-js#52 * PR to bump deps in `opentelemetry-instrumentation-fetch-node`: gas-buddy/opentelemetry-instrumentation-fetch-node#17 (which will also be superseded by #13485 eventually) * Closes #11499
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #1606
Which problem is this PR solving?
Related: getsentry/sentry-javascript#11499
Short description of the changes
Mongoose 7
removeMongoose DocsMongoose 8
countMongoose DocsfindOneAndRemoveMongoose DocsThe current set of tests is passing without any issues, except
findOneAndUpdate, which starts to create only one span, starting from version 7. I separated that test for v7/v8.To avoid separating the package because of type mismatches, I have added a few
// @ts-expect-errors inside tests with their reasons.