-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🏃 Kcp scale down improvements #2381
🏃 Kcp scale down improvements #2381
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: detiber The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/assign @vincepri @chuckha @dlipovetsky |
/milestone v0.3.0-rc.2 |
/lgtm holding for the other two PRs to merge |
e3e1abb
to
cbd69fc
Compare
cbd69fc
to
1ee3f75
Compare
1ee3f75
to
678e2cc
Compare
/hold cancel This should be good to go now. |
/lgtm |
What this PR does / why we need it:
Lays the foundation for improved re-entrancy for scaling down KubeadmControlPlane
Related to #2242
Builds on #2379 #2380