Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Remove etcd membership when doing a KubeadmControlPlane scale down #2382

Merged
merged 1 commit into from
Feb 20, 2020
Merged

✨ Remove etcd membership when doing a KubeadmControlPlane scale down #2382

merged 1 commit into from
Feb 20, 2020

Conversation

detiber
Copy link
Member

@detiber detiber commented Feb 20, 2020

What this PR does / why we need it:
Properly removes etcd membership when doing a KubeadmControlPlane scale down

Related to #2242
Builds on #2379 #2380 #2381

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 20, 2020
@detiber
Copy link
Member Author

detiber commented Feb 20, 2020

/assign @vincepri @chuckha @dlipovetsky

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 20, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: detiber

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 20, 2020
This was referenced Feb 20, 2020
Merged
Merged
@vincepri
Copy link
Member

/milestone v0.3.0-rc.2

@k8s-ci-robot k8s-ci-robot added this to the v0.3.0-rc.2 milestone Feb 20, 2020
@ncdc ncdc added the area/control-plane Issues or PRs related to control-plane lifecycle management label Feb 20, 2020
@detiber
Copy link
Member Author

detiber commented Feb 20, 2020

/hold on prereqs

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 20, 2020
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 20, 2020
@detiber
Copy link
Member Author

detiber commented Feb 20, 2020

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 20, 2020
@detiber detiber mentioned this pull request Feb 20, 2020
Closed
chuckha
chuckha approved these changes Feb 20, 2020
View reviewed changes
Copy link
Contributor

@chuckha chuckha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To sum up these changes: the machine that is identified for deletion during scale down will have a marked for deletion label. If that same machine does not have the label indicating the etcd member has been removed, we then remove the etcd member and mark the machine as having its etcd member removed. This allows for better reentrancy during a scale down event

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 20, 2020
@k8s-ci-robot k8s-ci-robot merged commit 075c439 into kubernetes-sigs:master Feb 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@randomvariable randomvariable randomvariable left review comments

@vincepri vincepri vincepri left review comments

@chuckha chuckha chuckha approved these changes

@justinsb justinsb Awaiting requested review from justinsb

Assignees

@chuckha chuckha

@vincepri vincepri

@dlipovetsky dlipovetsky

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/control-plane Issues or PRs related to control-plane lifecycle management cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v0.3.0-rc.2
Development

Successfully merging this pull request may close these issues.
7 participants
@detiber @k8s-ci-robot @vincepri @chuckha @randomvariable @ncdc @dlipovetsky