Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix execution_resourceglobal vs. slot usage inconsistencies #168

Merged
merged 2 commits into from
May 17, 2024

Conversation

brynnz22
Copy link
Collaborator

I noticed in the documentation that execution_resource was showing up as having a range of string despite us implementing an ExecutionResourceEnum as its range in Berkeley. This was because the global definition of execution_resource had a range of string while under the WorkflowExecution class it had a range of ExecutionResourceEnum. I fixed this by:

  • changing the range on the global definition of execution_resource from string to ExecutionResourceEnum
  • I had to move the definition of ExecutionResourceEnum over to the same file execution_resource is globally defined on so it would pass the tests
  • I kept the slot usage for execution_resource on WorkflowExecution to make it required.

@brynnz22 brynnz22 marked this pull request as ready for review May 16, 2024 22:38
@brynnz22 brynnz22 requested a review from turbomam May 16, 2024 22:38
@brynnz22 brynnz22 self-assigned this May 16, 2024
@turbomam turbomam merged commit 9c7b997 into main May 17, 2024
2 checks passed
@turbomam turbomam deleted the fix_execution_resource branch May 17, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants