Add external analysis project identifiers slots to WorkflowChain
#47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbthornton-lbl
changed the title
mbthornton-lbl
changed the title
aclum
requested changes
Dec 19, 2023
There was a problem hiding this comment.
The new jgi.analysis prefix needs to be defined in prefixes: in nmdc.yaml
expansion should be https://data.jgi.doe.gov/search?q=
@turbomam I'm surprised to see this passing schema tests using a curie prefix that hasn't been defined.
…n' of https://github.com/microbiomedata/berkeley-schema-fy24 into 11232_add_external_analysis_identifiers_to_WorkflowChain
|
It looks like this PR does have an expansion for If I comment it out, the build and tests do go to completion, but there is a warning:
|
turbomam
approved these changes
Dec 19, 2023
|
@aclum I've added the jgi.analysis prefix and URL example |
aclum
reviewed
Dec 20, 2023
aclum
approved these changes
Dec 20, 2023
mbthornton-lbl
deleted the
11232_add_external_analysis_identifiers_to_WorkflowChain
branch
brynnz22
changed the title
WorkflowChain
|
no migration required |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1123
This PR provides:
-- gold_analysis_project_identifiers
-- jgi_portal_analysis_project_identifiers
jgi_portal_analysis_project_identifiersslot definition