-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add gold_analysis_project_identifiers and (new) jgi_analysis_project_identifiers to WorkflowChain #1123
Comments
Some of this should go in workflow chain Maybe! |
@mbthornton-lbl these slots are coming off Class:WorkflowExecution and will ONLY be on Class:WorkflowChain. Correct? |
Correct
…On Tue, Dec 19, 2023 at 5:03 PM Montana ***@***.***> wrote:
@mbthornton-lbl <https://github.com/mbthornton-lbl> these slots are
coming off Class:WorkflowExecution and will ONLY be on Class:WorkflowChain.
Correct?
—
Reply to this email directly, view it on GitHub
<#1123 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BB5L2CYW7SRI7KKU7HQWT33YKI2NZAVCNFSM6AAAAAA42PNSU2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNRTGY4DAMJZGI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Outstanding todo is to add img_identifiers to MetagenomeAnnotation and MagsAnalysis |
@aclum is the gold_analysis identifier part of this complete? Will img_identifiers be done here, or should that be a separate issue and PR? |
The Pr with both identifiers has been merged in. |
Linked PR addresses img_identifiers in WorkflowExeuction subclasses. |
In reviewing some things for the napa compliance squad I realized there is not a generic external_identifiers slot. For example all that exists on Class: MetagenomeAssembly is insdc_assembly_identifiers. JGI/GOLD and IMG have identifiers that are a direct or broad mapping. For example, img_identifiers which are currently on Class Biosample, a more appropriate mapping is https://microbiomedata.github.io/nmdc-schema/MetagenomeAnnotationActivity/ and https://microbiomedata.github.io/nmdc-schema/MagsAnalysisActivity/
Currently the workflows team uses the GOLD analysis project identifiers (Ga*) to name the directories when Ingesting the JGI workflow data, I'd like somewhere to store this in the schema so we can link back to what GOLD identifier generated the data. Currently I have to provide a table offline that maps the gold sequencing project, listed in the omics_processing_set record as https://microbiomedata.github.io/nmdc-schema/gold_sequencing_project_identifiers/ to GOLD analysis project identifiers which currently don't have a designated slot.
The text was updated successfully, but these errors were encountered: