add img_identifiers to WorkflowExecution subclasses
#71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add slot img_identifiers to annotation and binning.
IMG identifiers should be 1:1 with NMDC workflow execution subclasses so adding slot usage for img_identifiers to be multivalued false when used for these classes.
Adding example img_identifiers value.
mbthornton-lbl
approved these changes
Jan 23, 2024
turbomam
requested changes
Jan 24, 2024
…rdinality of 1, update example data
turbomam
approved these changes
Jan 24, 2024
aclum
deleted the
1123-add-img-identifiers-to-WorkflowExecution-subclasses
branch
brynnz22
changed the title
img_identifiers to WorkflowExecution subclasses
brynnz22
changed the title
img_identifiers to WorkflowExecution subclassesimg_identifiers to WorkflowExecution subclasses
|
img_identifiers were on other class, now they're also WorkflowExecution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR to add img_identifieres to appropriate WorkflowExecution subclasses.
Migration is not strictly needed as these are additive but there are some projects where we'll want to move the identifiers from class Biosample to the WorkflowExecutions subclasses. We do still need to figure out what to do with IMG datasets that we want to link to but not necessarily host, older IMG records, combined assemblies, etc. For now I've left img_identifiers on Biosample.