1736 add associated_studies to biosample
#79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brynnz22
added
migration-needed
brynnz22
requested review from
mslarae13,
anastasiyaprymolenna,
turbomam,
aclum and
cmungall
aclum
reviewed
Jan 29, 2024
There was a problem hiding this comment.
@turbomam to weigh in here but I think we'd want associated_studies to be required: true globally, otherwise data portal code won't work. I see you took part_of out as required but that looked like it was just locally defined as required.
aclum
approved these changes
Jan 30, 2024
brynnz22
changed the title
associated_studies to biosample
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR models the
Biosampleclass the same as the we did for theDataGenerationclass and parthood. It removes thepart_ofslot fromBiosampleand instead uses theassociated_studiesslot we created to link studies to their biosamples.For issue: microbiomedata#1736