Disable break for 4122 #4635
Closed
Disable break for 4122 #4635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Created new Microsoft.ReactNative.sln * Update PR to build vnext/Microsoft.ReactNative.sln * Add params to disable ReactUWP nuget pack during PR
* Move playground app to use Microsoft.ReactNative * formatting * Bunch of code review feedback * Change files * formatting * Delete unneeded gitignore * Minor removal of diff * Minor changes to try to avoid having to update cert all the time * Fix bundle command * No need to build rntester seperately, the release build of playground will do it from msbuild * Remove test property
* Disable .net native for managed unit tests * Change files * Enable managed unit tests in ci loop * re-merge unit test tasks, can't run arm anyway * Remove prefer 32bit from 64bit flavors * Update mstest dependencies * Managed tests are separate again * Add comment * Add test adapter path * x86 debug again * Update test adapter folder * Try again * remove frameworkuap10 * Switch to appxrecipie * Try to switch to installed version of vstest * Remove installer task
* Prototype mockable MessageQueueThread and JSExecutor * Declare MockJSExecutor::CallFunctionFunctor * Add missing using std::unique_ptr * Use WebSocketModule::MethodId * clang format * Make WebSocketModule methods override instead of virtual. * Allow WebSocketModule to use custom resource factory * Rename *Impl to *Mock * Move Instance mocks into separate source files * Move Instance mocks into separate source files * Change files * clang format * Define WebSocketModule::SetResourceFactory
-Surface msbuild errors (shows as undefined right now) -downloading nuget with Invoke-WebRequest will usually take a long time because of the PS progress bar (which sadly gets updated for every byte), so I'm disabling the progress bar (it only takes a second to download when the progress bar is turned off) retry once if nuget failed since if you cancel at just the right time, you could end up with a truncated nuget.exe and are wedged unless you know which file to delete. Learned that the hard way. -factor out calling onto powershell functions -we were not exposing whether the function failed or not
* Don't set readyState on connection error * Change files
* Simplified C++ macros and improved their comments * Change files
* Remove Folly ContinueOnError After upgrading to v142 build tools we no longer see MSBuild throwing up on unzip failure. Remove ContinueOnError. * Change files
* add missing headers to proj file * Change files
* Upgrade to 0.62 * Update the issue number in a few override entries * Image.ios -> Image.windows * Update override-tools UT to Expect Override File as a validation error for baseFileNotFound Co-authored-by: Andrew Coates (REDMOND) <acoates@microsoft.com>
* bug fix, update test * Change files
…oft#4608) * Rename DeveloperSettings.SourceBundlePath -> SourceBundleName * Change files * clang format
* Updated README in root master This updates the README to remove references of vnext as well as fix some links and reword sections to be more in-line with our thinking and current progress. * link typo fix * Update README.md Changed a linkt to use the new react native website url. * Fixed some links, added information needed back. * Update README.md Fixed the template link for issue reporting to link to just the chooser. * Links out to sys reqs on doc site add to sys reqs section Co-authored-by: Kiki Saintonge <kisai@microsoft.com>
…orms (microsoft#4576) * Use a custom resolver wrapper to allow metro to run for multiple platforms at once * Change files * More simplification of metro configs * CI fixes * Fix bundle command on init app to properly use windows platform * More simplification of metro configs * Fix asset loading
* Fix PickerWindows (and DatePickerExample Page) Fixes microsoft#4597 Our implementation of Picker is a bit deformed. In Stock React Native, Picker.js will delegate to PickerAndroid and PickerIOS. In Windows, we the two are copy pasted. In 0.62, invariants are added to prevent duplicate view manager registration. We run into issues with this with Picker, since our copies will both call requireNativeComponent. This change modifies the normal picker to delegate to PickerWindows to work correctly from the stock picker. I.e. The stock picker's child views are meant for data only and will throw if rendered, where the Windows version's are included but used to noop render. Picker is getting lean-cored, so I didn't invest much into fixing PickerWindow's isssues, converting to Flow, NativeComponent strucutre, etc. Validated Picker, PickerWindows, DatePicker RNTester pages work correctly. * Change files
microsoft#4604) * Use more of the CLI rather than custom build steps to validate new projects * Switch master to only publish nightly * syntax * syntax * typo * Test * test * syntax * fix cwd * Add msbuild.ProjectImports.zip to default blacklist to avoid metro error on run-windows * Change files * Use a local version of nuget if available * review feedback * put private nuget package where nuget will find it * Another attempt to get cli to pick up private nuget * syntax * typo
…icrosoft#4585) Improve/refactor e2etest and TreeDumpLibrary in a number of ways: most importantly is that we've had test break but not fail the PR or CI - this is because wdio which we use as a test harness, does not set its exit code on success/failure, which is needed for Azure Pipelines to know whether it should fail the build or not. image Because we were blind to test failures, the outputs have drifted away from the original masters. I'm re-baselining them based on what we have today. Component owners should do a pass on the new masters to make sure nothing looks weird (e.g. ImageRTL still shows FlowDirection=LeftToRight). Filed microsoft#4589 to track this. changes the test app UI to provide links to the master and output files, and to diff the two. I wanted to launch vscode in diff mode for that but since we are a UWP app, the only way we can launch a program like that is to use a protocol handler, which vscode doesn't expose for diffing. Filed: Provide a protocol handler for diffing two files. For the time being, we'll copy the command line to launch vscode in diff mode for the two files. Adds the ability for the tree dump library to output json which will allow us to write tests that validate the output from the javascript side Adds logic for optionally output the name of elements. I plan to turn this and json output on soon but wanted to get a baseline PR/CI first. e2etest was crashing because of a bug in Switch: microsoft#4596 . Disabled that control in the test app for the time being. Added logic to the pipeline to capture crash dumps when e2etest app crashes Added checks to make sure we don't try to build/run the e2etest app in scenarios where it isn't really supported because the masters would not match (anything other than Release|x64 at 100% DPI). There are bugs tracking these limitations that we must fix before rtm: microsoft#4122 and microsoft#4619
* Implement AccessibilityState * formatting * Change files * bring back accessibilityStates to port back to 0.61 * formatting * handle mixed state * update test * prettier fixes
* remove AccessibilityStates * Change files
…oft#4609) * Change files * Fix build for ReactUwp/Win32 Playground * Yarn format * Remove unneeded module
* Remove Clang Format Pre-Commit Hook I don't think this fully works correcty, and unlike lint-staged, `yarn format` has a pretty significant latency. Remove the hook for now. * Remove Husky
* Implement AppearanceModule This change adds an implementation of AppearanceModule. This ends up being a little bit hairy, since it exposes sync methods, but on Windows we can only check app theme on the UI thread. We could have reused the model of AppTheme and asked to construct some partial state on the UI thread and pass to the module, but this ends up being somewhat cumbersome. We instead will post to the UI thread internally, and block on a result before returning initial data. This should never happen in practice. Validated we can correctly switch between light-mode and dark-mode RNTester when not using web debugging (where Appearance is disabled JS side since Chrome can't handle sync methods). * Change files * Revert an accidental change * Fix Build For ReactUwp/Win32 Playground * Address Feedback
* Allow enabling of direct debugging through the CLI. * Use more accurate declartions. * Enable direct debugging through command line arguments instead of defines. * Addres PR feedback. * Use same delimiter as when running through the react native CLI. * Change delimiter back to whitespace. * Address PR feedback.
* Fix issue with yoga layout in x64 release * Change files * Update E2E masters * code review feedback
* Added initial implementation * Add backrequested listener * Add handlers for other back actions Also remove debug code * Change files * Remove TODO * Responding to PR comments * Copied in Android BackHandler code from upstream * Changed the base file for the BackHandler override * Fixed weak ptr check * Removed unnecessary validation after casting XamlView to UIElement * Call JS with legacyPointer * More PR feedback * Use weak pointers to this in event handlers * Fix safety issue in query_cast * Revoke handlers on Uninit * Remove added binary file * use weak ptr for BackRequested too * Fix override hash verification
* fix include paths * Change files * fix include paths
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that #4122 is fixed, remove the guard rail I added to e2etest
Microsoft Reviewers: Open in CodeFlow