constrain IMU filter length #348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* value of 0 stops IMU from publishing Signed-off-by: Mateusz Żak <mateusz.zak@robotec.ai>
spham-amzn
reviewed
May 26, 2023
* also change UIHandler to improve UX Signed-off-by: Mateusz Żak <mateusz.zak@robotec.ai>
adamdbrw
approved these changes
Jun 12, 2023
michalpelka
approved these changes
Jun 13, 2023
arturkamieniecki
pushed a commit
to arturkamieniecki/o3de-extras
that referenced
this pull request
Jul 5, 2023
* Constrain IMU filter size Signed-off-by: Mateusz Żak <mateusz.zak@robotec.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the IMU's filter length is set to 0 sensor fails to publish data. This PR is adding a constraint on the IMU component's
Filter Lengthproperty as only positive values make sense