Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

constrain IMU filter length #348

Merged
merged 2 commits into from
Jun 13, 2023
Merged

constrain IMU filter length #348

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d155f22
constrain filter size
zakmat May 24, 2023
21e175c
add a maximum value according to review
zakmat Jun 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions Gems/ROS2/Code/Source/Imu/ROS2ImuSensorComponent.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,10 +46,12 @@ namespace ROS2
->Attribute(AZ::Edit::Attributes::Category, "ROS2")
->Attribute(AZ::Edit::Attributes::AppearsInAddComponentMenu, AZ_CRC_CE("Game"))
->DataElement(
AZ::Edit::UIHandlers::Default,
AZ::Edit::UIHandlers::Slider,
&ROS2ImuSensorComponent::m_filterSize,
"Filter Length",
"Filter Length, large value allows to reduce numeric noise")
"Filter Length, Large value reduce numeric noise but increase lag")
->Attribute(AZ::Edit::Attributes::Min, 1)
zakmat marked this conversation as resolved.
Show resolved Hide resolved
->Attribute(AZ::Edit::Attributes::Max, 200)
->DataElement(
AZ::Edit::UIHandlers::Default,
&ROS2ImuSensorComponent::m_includeGravity,
Expand Down