Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only][full-ci] Added API tests to check file versions of shared file from project space by a sharee #7829

Merged
merged 1 commit into from
Dec 14, 2023
Merged

[tests-only][full-ci] Added API tests to check file versions of shared file from project space by a sharee #7829

merged 1 commit into from
Dec 14, 2023

Conversation

nirajacharya2
Copy link
Contributor

@nirajacharya2 nirajacharya2 commented Nov 28, 2023 •
edited by saw-jan
Loading

Description

Added API tests for checking file versions of shared file from a space (file shared with different role)

Scenario Outline: check the file versions of a shared file
    Examples:
      | role   | 
      | editor | 
      | viewer |
      | all    |

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@nirajacharya2 nirajacharya2 self-assigned this Nov 28, 2023
@nirajacharya2 nirajacharya2 force-pushed the hide-file-versions branch 3 times, most recently from 24cd7d5 to fefc5ce Compare December 6, 2023 03:42
@nirajacharya2 nirajacharya2 marked this pull request as ready for review December 6, 2023 04:50
@nirajacharya2 nirajacharya2 force-pushed the hide-file-versions branch 3 times, most recently from cce22c9 to 35679ad Compare December 8, 2023 06:08
@nirajacharya2 nirajacharya2 force-pushed the hide-file-versions branch 2 times, most recently from f977333 to 3589ee7 Compare December 11, 2023 03:42
@SagarGi SagarGi requested a review from saw-jan December 12, 2023 04:06
saw-jan
saw-jan approved these changes Dec 13, 2023
View reviewed changes
Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@saw-jan saw-jan requested review from ScharfViktor and removed request for phil-davis December 13, 2023 10:56
ScharfViktor
ScharfViktor approved these changes Dec 13, 2023
View reviewed changes
Copy link
Contributor

@ScharfViktor ScharfViktor left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please check what behavior if you share space with a file to user.
Can he see the version of the file and what role should he have?
do we have test for that?

of course in different PR

@nirajacharya2
Copy link
Contributor Author

Could you please check what behavior if you share space with a file to user. Can he see the version of the file and what role should he have?

if the space is shared with editor permission then only he can see the file versions.

do we have test for that?

i don't think we have such tests for project spaces.

@nirajacharya2 nirajacharya2 mentioned this pull request Dec 14, 2023
Closed
5 tasks
@saw-jan saw-jan changed the title [tests-only][full-ci] api test for hide file version [tests-only][full-ci] Added API tests to check file versions of shared file from project space by a sharee Dec 14, 2023
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 14, 2023

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@saw-jan saw-jan merged commit dd12844 into master Dec 14, 2023
4 checks passed
@delete-merged-branch delete-merged-branch bot deleted the hide-file-versions branch December 14, 2023 08:59
ownclouders pushed a commit that referenced this pull request Dec 14, 2023
@nirajacharya2
adding test for file version of a share in a projectspace (#7829)
1ae829a
@saw-jan saw-jan mentioned this pull request Dec 14, 2023
Merged
9 tasks
@nirajacharya2 nirajacharya2 mentioned this pull request Dec 15, 2023
Merged
9 tasks
2403905 pushed a commit to 2403905/ocis that referenced this pull request Jan 24, 2024
@nirajacharya2 @2403905
adding test for file version of a share in a projectspace (owncloud#7829
7033aca 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saw-jan saw-jan saw-jan approved these changes

@amrita-shrestha amrita-shrestha Awaiting requested review from amrita-shrestha

@nabim777 nabim777 Awaiting requested review from nabim777

@S-Panta S-Panta Awaiting requested review from S-Panta

@SwikritiT SwikritiT Awaiting requested review from SwikritiT

@PrajwolAmatya PrajwolAmatya Awaiting requested review from PrajwolAmatya

@SagarGi SagarGi Awaiting requested review from SagarGi

@ScharfViktor ScharfViktor Awaiting requested review from ScharfViktor

Assignees

@nirajacharya2 nirajacharya2

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@nirajacharya2 @SwikritiT @SagarGi @saw-jan @PrajwolAmatya @ScharfViktor