Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only][full-ci] Added API tests to check file versions of a file inside a shared space #7969

Merged
merged 2 commits into from
Dec 14, 2023
Merged

[tests-only][full-ci] Added API tests to check file versions of a file inside a shared space #7969

merged 2 commits into from
Dec 14, 2023

Conversation

nirajacharya2
Copy link
Contributor

@nirajacharya2 nirajacharya2 commented Dec 14, 2023 •
edited
Loading

Description

Added API tests for checking file versions of a file in a shared space (file shared with different role)

Scenario Outline: check the file versions of a file in a shared space as editor/manager
Scenario Outline: check the file versions of a file in a shared space as viewer

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@nirajacharya2 nirajacharya2 self-assigned this Dec 14, 2023
@nirajacharya2 nirajacharya2 mentioned this pull request Dec 14, 2023
Closed
5 tasks
@nirajacharya2 nirajacharya2 marked this pull request as ready for review December 14, 2023 09:20
@saw-jan
Copy link
Member

saw-jan commented Dec 14, 2023 •
edited
Loading

Please, add some description. Mentioning the test scenarios added would be helpful.
Similar to #7829

@SwikritiT SwikritiT changed the title [tests-only][full-ci] Adding API tests to check file versions of a file inside a apace [tests-only][full-ci] Adding API tests to check file versions of a file inside a space Dec 14, 2023
@saw-jan saw-jan changed the title [tests-only][full-ci] Adding API tests to check file versions of a file inside a space [tests-only][full-ci] Added API tests to check file versions of a file inside a shared space Dec 14, 2023
@nirajacharya2 nirajacharya2 force-pushed the hide-file-versions-space branch 2 times, most recently from 5c57eaa to 3c9cb6d Compare December 14, 2023 10:13
@nirajacharya2 nirajacharya2 force-pushed the hide-file-versions-space branch 2 times, most recently from e38f33c to 869157d Compare December 14, 2023 10:54
@nirajacharya2 nirajacharya2 force-pushed the hide-file-versions-space branch 3 times, most recently from acd2aef to 68d84b4 Compare December 14, 2023 10:56
saw-jan
saw-jan approved these changes Dec 14, 2023
View reviewed changes
Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 ✨

@saw-jan saw-jan removed the request for review from phil-davis December 14, 2023 11:25
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 14, 2023

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@ScharfViktor ScharfViktor merged commit 0314336 into master Dec 14, 2023
4 checks passed
@delete-merged-branch delete-merged-branch bot deleted the hide-file-versions-space branch December 14, 2023 13:51
ownclouders pushed a commit that referenced this pull request Dec 14, 2023
@nirajacharya2
[tests-only][full-ci] Added API tests to check file versions of a fil…
985b609 
…e inside a shared space (#7969)

* adding test for file version of a share in a projectspace

* adding test for listing file version of a file inside project space
@nirajacharya2 nirajacharya2 mentioned this pull request Dec 15, 2023
Merged
9 tasks
@nirajacharya2 nirajacharya2 mentioned this pull request Jan 10, 2024
Merged
9 tasks
2403905 pushed a commit to 2403905/ocis that referenced this pull request Jan 24, 2024
@nirajacharya2 @2403905
[tests-only][full-ci] Added API tests to check file versions of a fil…
e39319d 
…e inside a shared space (owncloud#7969)

* adding test for file version of a share in a projectspace

* adding test for listing file version of a file inside project space
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PrajwolAmatya PrajwolAmatya PrajwolAmatya left review comments

@saw-jan saw-jan saw-jan approved these changes

@ScharfViktor ScharfViktor ScharfViktor approved these changes

@grgprarup grgprarup Awaiting requested review from grgprarup

@SwikritiT SwikritiT Awaiting requested review from SwikritiT

@SagarGi SagarGi Awaiting requested review from SagarGi

@amrita-shrestha amrita-shrestha Awaiting requested review from amrita-shrestha

@S-Panta S-Panta Awaiting requested review from S-Panta

Assignees

@nirajacharya2 nirajacharya2

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nirajacharya2 @saw-jan @PrajwolAmatya @ScharfViktor