Skip to content
This repository has been archived by the owner on Nov 18, 2020. It is now read-only.

Implement the hipe_compile command #178

Closed
michaelklishin opened this issue Mar 8, 2017 · 4 comments
Closed

Implement the hipe_compile command #178

michaelklishin opened this issue Mar 8, 2017 · 4 comments
Assignees
@michaelklishin
Labels
effort-low
Milestone
3.7.0

Comments

@michaelklishin
Copy link
Member

Originally contributed in rabbitmq/rabbitmq-server#808, it slipped under the radar.
@michaelklishin michaelklishin added this to the 3.7.0 milestone Mar 8, 2017
@michaelklishin michaelklishin self-assigned this Mar 8, 2017
@michaelklishin
Copy link
Member Author

So this one is quite tricky in 3.7.0: we don't want to add a server dependency to CLI tools, so perhaps this should be an optional plugin that depends on it. @binarin WDYT?

@michaelklishin
Copy link
Member Author

OK, so it turns out we already load the rabbit app (the server) to support --offline in rabbitmq-plugins, so this command can be ported more or less as it is in 3.6.x.

michaelklishin added a commit to rabbitmq/rabbitmq-server that referenced this issue Mar 10, 2017
@michaelklishin
rabbit_hipe:compile_to_directory/1 should coerce argument to list
5efbb89 
Elixir callers such as rabbitmq-cli may use a binary.

References rabbitmq/rabbitmq-cli#178.
michaelklishin added a commit that referenced this issue Mar 10, 2017
@michaelklishin
Finish hipe_compile command
b8a8249 
This correctly handles the case where the rabbit app is
already loaded.

References #178.
This was referenced Mar 10, 2017
Merged
Merged
michaelklishin added a commit that referenced this issue Mar 13, 2017
@michaelklishin
rabbit app is loaded during validation; handle "already compiled" cases
dc867fb 
References #178.
michaelklishin added a commit that referenced this issue Mar 13, 2017
@michaelklishin
hipe_compile: reject blank, non-existent paths and those with insuffi…
d0cb138 
…cient permissions

References #178.
@cd21h
Copy link

cd21h commented Nov 27, 2018

Guys, quick question: once I ran rabbitmqctl hipe_compile and set RABBITMQ_SERVER_CODE_PATH, should I remove hipe_compile=true from rabbitmq.conf?

Would it be enough to use pre-compiled binaries?

Thanks

@lukebakken
Copy link
Contributor

@Shatl would you mind posting that question to the rabbitmq-users mailing list? That way other people can learn from the answer. Thank you.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@michaelklishin michaelklishin

Labels
effort-low
Projects
None yet
Milestone
3.7.0
Development

No branches or pull requests
3 participants
@michaelklishin @cd21h @lukebakken