Allow caching HiPE-compilation results #808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| {ok, _, _} = rabbit_hipe:compile_to_directory(TargetDir), | ||
| ok; | ||
| false -> | ||
| "HiPE compilation is not supported" |
There was a problem hiding this comment.
Should this be {error, Msg}?
There was a problem hiding this comment.
Yes, you're right. While printed result will be the same, it's better to be explicit.
That way HiPE compilation can be performed during package installation and will not waste time during every startup. rabbit_hipe is refactored to support both modes of compilation - during every server startup or separately with caching in the filesystem.
binarin
force-pushed
the
rabbitmq-server-cached-hipe-compilation
branch
from
9b89347
to
4dd4fd6
Compare
This was referenced Mar 8, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That way HiPE compilation can be performed during package installation
and will not waste time during every startup.
rabbit_hipe is refactored to support both modes of compilation - during
every server startup or separately with caching in the filesystem.