This repository has been archived by the owner on Nov 18, 2020. It is now read-only.
Implement rabbitmqctl hipe_compile
#179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This command needs access to RabbitMQ modules and currently propagation doesn't work as expected.
This correctly handles the case where the rabbit app is already loaded. References #178.
hairyhum
suggested changes
Mar 13, 2017
| def validate(_, _), do: {:validation_failure, :too_many_args} | ||
|
|
||
| def run([target_dir], _opts) do | ||
| case Application.load(:rabbit) do |
There was a problem hiding this comment.
Do we need to do Application.load again?
It should be called during validation.
| {:error, {:already_loaded, :rabbit}} -> | ||
| Code.ensure_loaded(:rabbit_hipe) | ||
| hipe_compile(target_dir) | ||
| :ok; |
There was a problem hiding this comment.
An error message from the previous line will never be shown.
| defp hipe_compile(target_dir) do | ||
| case :rabbit_hipe.can_hipe_compile() do | ||
| true -> | ||
| {:ok, _, _} = :rabbit_hipe.compile_to_directory(target_dir) |
There was a problem hiding this comment.
{ok, already_compiled} will not be matched.
There was a problem hiding this comment.
Normally, it won't be returned, because compile_to_directory will clean the directory before compiling, but the code is in different repo and the change can easily slip through the cracks.
|
Empty string for directory crashes the command |
…cient permissions References #178.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally introduced in rabbitmq/rabbitmq-server#808.
Fixes #178.