tests: shut down redpanda node after decom #5708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use a node object rather than a json dict, this enables the subequent commit that does a stop_node.
Once we improve redpanda to make decommed nodes stop serving Kafka traffic, this won't be necessary. Right now, redpanda does require that decommed nodes are stopped in order to avoid confusing clients, so the test should do that. Fixes redpanda-data#3277
jcsp
force-pushed
the
issue-3277-shutdown-after-decom
branch
from
64f4f76
to
5d80c90
Compare
|
Looks likw backports may be required: #3277 (comment) |
mmaslankaprv
approved these changes
Aug 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cover letter
Once we improve redpanda to make decommed nodes stop serving
Kafka traffic, this won't be necessary. Right now, redpanda
does require that decommed nodes are stopped in order to avoid
confusing clients, so the test should do that.
Fixes #3277
UX changes
None
Release notes